From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 890AE21FF2B; Mon, 23 Jun 2025 22:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716632; cv=none; b=livu+3v6U7kBy68u0pm+4aEe649reZb5RJgW5LrpFphq9GooQiiTCy95d3V9xTHhT+I+IVd1qoJWkGvEVD0dhpZ89q2HJEnMVtYaO16JiknAsQNdiDobspkjOR7zoB8qKrTcZHLXMy5SqfO5H92RVEKOun26LdljhzRWZ0bt4KQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750716632; c=relaxed/simple; bh=/ghtPXo/LS1La+oxwOtR7uutwpubueVKOk3gTX7VwRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0SEbYsKKcOvnAqoMkl8JYELofva9tbCNvIPSjPu1Qj9rBJNfXkq/LOzMCR4Vv/ZDjyvLRnlQdaV5rPNCZWKH4n4+xpJUuC9a+yWp4VCE+aM4n4urgqjZXhEk9dPVJyGvkH+1hX7tiHPe35ngBj12Z5nq8xZIzRlXAkLlhK6po0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qs/EH0nO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qs/EH0nO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 226E9C4CEEA; Mon, 23 Jun 2025 22:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1750716632; bh=/ghtPXo/LS1La+oxwOtR7uutwpubueVKOk3gTX7VwRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qs/EH0nOmT8zxZWNVBOGN6S+EVZSm007Q3PmXYv0+G6gSUW6IcpPDCHKSawllWJ4m wYO8VE6yoB4t//Ueka47yLKrH+MpC9EId0hbw1V3p1Uxox0ooFn3PzxEMyzLgEWySl 4dEJhBmWMOSyyoDAm/q7ncvkUvb2in0MRtAj5U2g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, maher azz , Matt Porter , Alexandre Bounine , Linus Torvalds , Andrew Morton Subject: [PATCH 5.15 346/411] drivers/rapidio/rio_cm.c: prevent possible heap overwrite Date: Mon, 23 Jun 2025 15:08:10 +0200 Message-ID: <20250623130642.357654124@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250623130632.993849527@linuxfoundation.org> References: <20250623130632.993849527@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Morton commit 50695153d7ddde3b1696dbf0085be0033bf3ddb3 upstream. In riocm_cdev_ioctl(RIO_CM_CHAN_SEND) -> cm_chan_msg_send() -> riocm_ch_send() cm_chan_msg_send() checks that userspace didn't send too much data but riocm_ch_send() failed to check that userspace sent sufficient data. The result is that riocm_ch_send() can write to fields in the rio_ch_chan_hdr which were outside the bounds of the space which cm_chan_msg_send() allocated. Address this by teaching riocm_ch_send() to check that the entire rio_ch_chan_hdr was copied in from userspace. Reported-by: maher azz Cc: Matt Porter Cc: Alexandre Bounine Cc: Linus Torvalds Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/rapidio/rio_cm.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/rapidio/rio_cm.c +++ b/drivers/rapidio/rio_cm.c @@ -787,6 +787,9 @@ static int riocm_ch_send(u16 ch_id, void if (buf == NULL || ch_id == 0 || len == 0 || len > RIO_MAX_MSG_SIZE) return -EINVAL; + if (len < sizeof(struct rio_ch_chan_hdr)) + return -EINVAL; /* insufficient data from user */ + ch = riocm_get_channel(ch_id); if (!ch) { riocm_error("%s(%d) ch_%d not found", current->comm,