From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB92224B1F; Thu, 3 Jul 2025 15:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751556148; cv=none; b=at7Mwg+w2ezEem2KTdo593lnpDFvUJg90UqXgQyXfRSaIO3cHah71ykasasYKqiL75B9CU86d5n3o6shWIYfEakQtu0dIEMlBKvf6BSNIc35tudOkOtpbygq612mPKFBeyJjY0/ttFYMVphRQhqGEePKW/0SYQrHs0/EbELHddc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751556148; c=relaxed/simple; bh=/bKVHjQAIcEMWZo2aPmi/YSEmUrq4Yo6qwb0iTlH++g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AR25ZWCq383moV07YCLLGHnJeE4IZHLcllu2Ji3e4R1mtXRO1zgCs/Jt3FvwqsBiAwU6SaWMsNmcpycGW9wOAN78ZDyE8oof16W47uX+bK3EUzR4BSwwk0fy9cMUAhaPe2uCXk8p1S4DomjBYMEcbYYC3ya+ehz7sTPoOXcWTvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1rt013EO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1rt013EO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8F69C4CEE3; Thu, 3 Jul 2025 15:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1751556148; bh=/bKVHjQAIcEMWZo2aPmi/YSEmUrq4Yo6qwb0iTlH++g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1rt013EOs+53j1qeQJrHTmJIlbu1Zj4g9Jb8erKq5wJKO0eYuAoA+hvpYujmJlVZd 0Pkj09oAovvKOpALLlVq8nc+Uc9c/jTq9P9wn+bMnfg+9HhwRu5WhM7qc+3Un/OJn7 tJ8T5a+lAxDHr2bnMzG7fq4/H20D9bm2HcVfJqdw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Janne Grunau , Alyssa Rosenzweig , Marc Zyngier , Manivannan Sadhasivam , "Rob Herring (Arm)" , Sasha Levin Subject: [PATCH 6.1 062/132] PCI: apple: Set only available ports up Date: Thu, 3 Jul 2025 16:42:31 +0200 Message-ID: <20250703143941.850191260@linuxfoundation.org> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250703143939.370927276@linuxfoundation.org> References: <20250703143939.370927276@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Janne Grunau [ Upstream commit 751bec089c4eed486578994abd2c5395f08d0302 ] Iterating over disabled ports results in of_irq_parse_raw() parsing the wrong "interrupt-map" entries, as it takes the status of the node into account. This became apparent after disabling unused PCIe ports in the Apple Silicon device trees instead of deleting them. Switching from for_each_child_of_node_scoped() to for_each_available_child_of_node_scoped() solves this issue. Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") Fixes: a0189fdfb73d ("arm64: dts: apple: t8103: Disable unused PCIe ports") Signed-off-by: Janne Grunau Signed-off-by: Alyssa Rosenzweig Signed-off-by: Marc Zyngier Signed-off-by: Manivannan Sadhasivam Tested-by: Janne Grunau Reviewed-by: Rob Herring (Arm) Reviewed-by: Manivannan Sadhasivam Acked-by: Alyssa Rosenzweig Cc: stable@vger.kernel.org Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@jannau.net/ Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/ Link: https://patch.msgid.link/20250401091713.2765724-2-maz@kernel.org Signed-off-by: Sasha Levin --- drivers/pci/controller/pcie-apple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c index b1f32e4c65989..1113e21ee386c 100644 --- a/drivers/pci/controller/pcie-apple.c +++ b/drivers/pci/controller/pcie-apple.c @@ -789,7 +789,7 @@ static int apple_pcie_init(struct pci_config_window *cfg) if (ret) return ret; - for_each_child_of_node_scoped(dev->of_node, of_port) { + for_each_available_child_of_node_scoped(dev->of_node, of_port) { ret = apple_pcie_setup_port(pcie, of_port); if (ret) { dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret); -- 2.39.5