From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Rahul Chandra" <rahul@chandra.net>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Sasha Levin" <sashal@kernel.org>,
corentin.chary@gmail.com, hdegoede@redhat.com,
markgross@kernel.org, acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org
Subject: [PATCH AUTOSEL 6.15 7/8] platform/x86: asus-nb-wmi: add DMI quirk for ASUS Zenbook Duo UX8406CA
Date: Mon, 7 Jul 2025 20:02:14 -0400 [thread overview]
Message-ID: <20250708000215.793090-7-sashal@kernel.org> (raw)
In-Reply-To: <20250708000215.793090-1-sashal@kernel.org>
From: Rahul Chandra <rahul@chandra.net>
[ Upstream commit 7dc6b2d3b5503bcafebbeaf9818112bf367107b4 ]
Add a DMI quirk entry for the ASUS Zenbook Duo UX8406CA 2025 model to use
the existing zenbook duo keyboard quirk.
Signed-off-by: Rahul Chandra <rahul@chandra.net>
Link: https://lore.kernel.org/r/20250624073301.602070-1-rahul@chandra.net
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
**YES**
This commit should be backported to stable kernel trees. Here's the
extensive explanation:
## Analysis of the Code Changes
The commit adds a simple DMI quirk entry for the ASUS Zenbook Duo
UX8406CA:
```c
+ {
+ .callback = dmi_matched,
+ .ident = "ASUS Zenbook Duo UX8406CA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER
INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "UX8406CA"),
+ },
+ .driver_data = &quirk_asus_zenbook_duo_kbd,
+ },
```
This applies the existing `quirk_asus_zenbook_duo_kbd` to the UX8406CA
model.
## Why This Is a Bug Fix, Not Just Hardware Enablement
Based on my analysis of the kernel repository, the
`quirk_asus_zenbook_duo_kbd` was introduced to fix a specific hardware
issue where:
1. **The keyboard emits spurious wireless disable keypresses** when
placed on the laptop's secondary display
2. **This causes unexpected WiFi disconnections** via the rfkill system
3. **The keyboard doesn't actually have wireless toggle functionality**,
so these events are always spurious
## Evidence Supporting Backporting
1. **Fixes User-Impacting Bug**: Without this quirk, users experience
unexpected WiFi disconnections when using their keyboard normally,
which significantly impacts usability.
2. **Follows Established Pattern**: The commit follows the exact pattern
of the previous UX8406MA support (commit 9286dfd5735b), which
addressed the same issue for a similar model.
3. **Minimal Risk**: The change is:
- Only 9 lines of code
- Isolated to specific hardware (only affects UX8406CA)
- Uses existing, tested infrastructure
- Cannot affect other systems due to DMI matching
4. **Similar to Other Backported Commits**: Looking at the reference
commits:
- Commit 2b1cb70 (adding support for ALS on UX430UQ) was backported
- Commit ac16dfa (reverting GA401/GA502 quirks) was backported
- Commit 82a7228 (adding tablet mode quirk for ROG Flow X13) was
backported
5. **Clear Bug Fix Nature**: Unlike commit 79493de (making use of
dmi->ident) which was NOT backported because it was just a code
improvement, this commit actually fixes broken functionality.
## Comparison with Reference Commits
This commit is most similar to:
- **Commit 2b1cb70** (YES): Added device-specific quirk to fix
functionality
- **Commit 82a7228** (YES): Added quirk to fix hardware-specific issue
- **Commit 25390f8** (YES): Added device support to fix existing
hardware
And dissimilar to:
- **Commit 79493de** (NO): Code refactoring without functional impact
## Conclusion
This commit meets all criteria for stable backporting:
- Fixes a real bug affecting users
- Small, contained change
- Low risk of regression
- Follows established patterns
- Only affects specific hardware
The commit should be backported to stable kernels that contain the
`quirk_asus_zenbook_duo_kbd` infrastructure (6.11+).
drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 3f8b2a324efdf..f84c3d03c1de7 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -530,6 +530,15 @@ static const struct dmi_system_id asus_quirks[] = {
},
.driver_data = &quirk_asus_zenbook_duo_kbd,
},
+ {
+ .callback = dmi_matched,
+ .ident = "ASUS Zenbook Duo UX8406CA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "UX8406CA"),
+ },
+ .driver_data = &quirk_asus_zenbook_duo_kbd,
+ },
{},
};
--
2.39.5
next prev parent reply other threads:[~2025-07-08 0:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 0:02 [PATCH AUTOSEL 6.15 1/8] Revert "ACPI: battery: negate current when discharging" Sasha Levin
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 2/8] virtio_net: Enforce minimum TX ring size for reliability Sasha Levin
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 3/8] virtio_ring: Fix error reporting in virtqueue_resize Sasha Levin
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 4/8] drm/amd/display: Don't allow OLED to go down to fully off Sasha Levin
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 5/8] regulator: core: fix NULL dereference on unbind due to stale coupling data Sasha Levin
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 6/8] PM: Restrict swap use to later in the suspend sequence Sasha Levin
2025-07-08 6:25 ` Pavel Machek
2025-07-08 6:39 ` Pavel Machek
2025-07-08 19:13 ` Eric W. Biederman
2025-07-08 19:32 ` Eric W. Biederman
2025-07-08 20:32 ` Sasha Levin
2025-07-08 20:37 ` Pavel Machek
2025-07-08 20:46 ` Willy Tarreau
2025-07-08 20:49 ` Pavel Machek
2025-07-08 21:12 ` Sasha Levin
2025-07-08 21:26 ` Pavel Machek
2025-07-09 5:34 ` Pavel Machek
2025-07-08 20:41 ` Pavel Machek
2025-07-08 21:46 ` Eric W. Biederman
2025-07-08 22:26 ` Sasha Levin
2025-07-09 5:39 ` Pavel Machek
2025-07-09 14:35 ` Mario Limonciello
2025-07-09 16:23 ` Eric W. Biederman
2025-07-09 16:35 ` Mario Limonciello
2025-07-09 16:55 ` Rafael J. Wysocki
2025-07-09 17:37 ` Sasha Levin
2025-07-08 20:38 ` Pavel Machek
2025-07-08 0:02 ` Sasha Levin [this message]
2025-07-08 0:02 ` [PATCH AUTOSEL 6.15 8/8] RDMA/core: Rate limit GID cache warning messages Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250708000215.793090-7-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=markgross@kernel.org \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rahul@chandra.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox