From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BBB82D372D; Tue, 15 Jul 2025 13:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586266; cv=none; b=D8q9LOAdMC4kqDOiv5C4mOwjsh9gcfOyDhSTgpKtQXkq7aD2MBJtQiy/L7thjKbCUk8sBHfew0Caxqb70a0bvmKT6EEr+dlpHdtg6Gbf0Bu2/ftUuWFVkQOOg7cl4G/Hkj3o2n5C3rxj7jc/wY7Y84Ai9f7aT9QxgKBBWahV7mc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586266; c=relaxed/simple; bh=5QMarY71F1EsUd6slF4n8NFmjGA955HX+CgY98KYkSY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dqq6yclK9MCBHy5nPuWr2nNLTO53pm1N6j/aq0Cc7QqsRu2986gLpr8uTN9qqwvYef3dZ+6wjoVvidC8xx5f/GZZNtLNPg27vfUie39W50E6uMgcTWMw6lGUpBCIj6ZMzU4w1uCQ+VG+/M8YxOho4ocV17XS4ZifAp2SjtMhrCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oTW5ScEF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oTW5ScEF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7555C4CEE3; Tue, 15 Jul 2025 13:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586266; bh=5QMarY71F1EsUd6slF4n8NFmjGA955HX+CgY98KYkSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oTW5ScEFVm+8swXYcZF/2nbF+U3KSB8G3T/4hw60vSonun2cvUXeDhemU8Vm251wK Nug41i1JI7qMTdF80WwpzdgVHWwbAQQaRX57RPudeSuXaMMLU62VJVyCKCYDTvwSw8 K38lDD51La/BSeNRZWqq+tQ7Azbosl1TjlGlfQgA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 67/77] atm: idt77252: Add missing `dma_map_error()` Date: Tue, 15 Jul 2025 15:14:06 +0200 Message-ID: <20250715130754.415683605@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130751.668489382@linuxfoundation.org> References: <20250715130751.668489382@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit c4890963350dcf4e9a909bae23665921fba4ad27 ] The DMA map functions can fail and should be tested for errors. Signed-off-by: Thomas Fourier Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250624064148.12815-3-fourier.thomas@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/atm/idt77252.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c index 7810f974b2ca9..d9ee20f0048fe 100644 --- a/drivers/atm/idt77252.c +++ b/drivers/atm/idt77252.c @@ -852,6 +852,8 @@ queue_skb(struct idt77252_dev *card, struct vc_map *vc, IDT77252_PRV_PADDR(skb) = dma_map_single(&card->pcidev->dev, skb->data, skb->len, DMA_TO_DEVICE); + if (dma_mapping_error(&card->pcidev->dev, IDT77252_PRV_PADDR(skb))) + return -ENOMEM; error = -EINVAL; @@ -1857,6 +1859,8 @@ add_rx_skb(struct idt77252_dev *card, int queue, paddr = dma_map_single(&card->pcidev->dev, skb->data, skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE); + if (dma_mapping_error(&card->pcidev->dev, paddr)) + goto outpoolrm; IDT77252_PRV_PADDR(skb) = paddr; if (push_rx_skb(card, skb, queue)) { @@ -1871,6 +1875,7 @@ add_rx_skb(struct idt77252_dev *card, int queue, dma_unmap_single(&card->pcidev->dev, IDT77252_PRV_PADDR(skb), skb_end_pointer(skb) - skb->data, DMA_FROM_DEVICE); +outpoolrm: handle = IDT77252_PRV_POOL(skb); card->sbpool[POOL_QUEUE(handle)].skb[POOL_INDEX(handle)] = NULL; -- 2.39.5