From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAEE2E49AA; Tue, 15 Jul 2025 13:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752587248; cv=none; b=oX9nwfRTqAfELi124xaIxty/iWUXGGMxOcXdUwCv4r0/5elbEZkawcCpfIO/r+4GgzS2BbWJp36Ts4j9vw+N3HwekKmmQDtuP4Uo9q5yaUrWBM0rRTd2jCn7qXvtvx/DvYPTmqCewvjuAZz4mJ2H65QjJRj1QC28f+UgCtNsG1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752587248; c=relaxed/simple; bh=6poJBil8kklFAwN4bJpcG5cLuEUOhRHhSLGo43UCn/g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QYHi8ZlTvEgO3gPmMuBielIlPdgaZTI3yEXdZfgHpAklp8Tj5FFzntYoruk8pbRnMD/o7MEVAUybR33PF0H8we6UnnfF0StxUJuEWVanlX7v0OC0DfvCcYveow0POU1ekKnahV7JfBiYdx22Fa81TMFu1Rl3VRqPVT2pSDcbsjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xpe229VU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xpe229VU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B54D4C4CEE3; Tue, 15 Jul 2025 13:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752587248; bh=6poJBil8kklFAwN4bJpcG5cLuEUOhRHhSLGo43UCn/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xpe229VUqwFdiEMkRJ85Afq6UOytPApucRC9uU4w8utlGdDH/J7yGtdxbCGeeMKCX A/GiURDnSgiYST+/4WqLSMNcmytWFX0N36nsN6fNwmjYflpMImtoKYWExhvdhy4Q1+ BLPuHu32eyCiXWsWCTOWkcjNyC/Qc/EhU3FeiAyE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gerald Gibson , =?UTF-8?q?H=C3=A5kon=20Bugge?= , Yu Kuai Subject: [PATCH 6.1 29/88] md/md-bitmap: fix GPF in bitmap_get_stats() Date: Tue, 15 Jul 2025 15:14:05 +0200 Message-ID: <20250715130755.690513858@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130754.497128560@linuxfoundation.org> References: <20250715130754.497128560@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Håkon Bugge commit c17fb542dbd1db745c9feac15617056506dd7195 upstream. The commit message of commit 6ec1f0239485 ("md/md-bitmap: fix stats collection for external bitmaps") states: Remove the external bitmap check as the statistics should be available regardless of bitmap storage location. Return -EINVAL only for invalid bitmap with no storage (neither in superblock nor in external file). But, the code does not adhere to the above, as it does only check for a valid super-block for "internal" bitmaps. Hence, we observe: Oops: GPF, probably for non-canonical address 0x1cd66f1f40000028 RIP: 0010:bitmap_get_stats+0x45/0xd0 Call Trace: seq_read_iter+0x2b9/0x46a seq_read+0x12f/0x180 proc_reg_read+0x57/0xb0 vfs_read+0xf6/0x380 ksys_read+0x6d/0xf0 do_syscall_64+0x8c/0x1b0 entry_SYSCALL_64_after_hwframe+0x76/0x7e We fix this by checking the existence of a super-block for both the internal and external case. Fixes: 6ec1f0239485 ("md/md-bitmap: fix stats collection for external bitmaps") Cc: stable@vger.kernel.org Reported-by: Gerald Gibson Signed-off-by: Håkon Bugge Link: https://lore.kernel.org/linux-raid/20250702091035.2061312-1-haakon.bugge@oracle.com Signed-off-by: Yu Kuai Signed-off-by: Greg Kroah-Hartman --- drivers/md/md-bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/md/md-bitmap.c +++ b/drivers/md/md-bitmap.c @@ -2029,8 +2029,7 @@ int md_bitmap_get_stats(struct bitmap *b if (!bitmap) return -ENOENT; - if (!bitmap->mddev->bitmap_info.external && - !bitmap->storage.sb_page) + if (!bitmap->storage.sb_page) return -EINVAL; sb = kmap_local_page(bitmap->storage.sb_page); stats->sync_size = le64_to_cpu(sb->sync_size);