From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471322E4984; Tue, 15 Jul 2025 13:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586386; cv=none; b=F8oaG5I4AmMcs0RE3nDg3gDbRiYHCCuTGTfX0l8RWOy/DF2Cv5bmHKmRjhG/SV2M3eRwvwP/XRDXJEABuB+TQVNu6Hsrche2PCeZsfZs/Cnedaacorw1e+w+PshR9rH3k3vum717hldJjD5mCynEwhF8JbBbXGJA9/x1oLkG3Pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586386; c=relaxed/simple; bh=8t+pWfPMqycDaaPV7g3k+81f6Dwuqt3BlsLCa5ZPBVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VqTIkakGGqFObdrTzA68kOGWXn8U64+ucSvU7gVHiE9AjrONyYhhAOKRtXN43xQve+ECvLiU5HM+OTWfPxHA7AuA++SFxskxnsmV1df2iCnsfNE4tvp8GHgCitAAA3fkE1Z3OJzif3Twlo1qpc+YF4lPHb9E7ga25P3iUSd9qdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wyE71Ufk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wyE71Ufk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7081DC4CEE3; Tue, 15 Jul 2025 13:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586385; bh=8t+pWfPMqycDaaPV7g3k+81f6Dwuqt3BlsLCa5ZPBVY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wyE71UfkWcYVRXIZpqg9kTjmx3i7cnuTeXvMs+9ic0QRcNDu5m1NwJNFxjKoMSaDm 8VyKluDHZfT1yTFwPgVemkmMcjOXCOhZqPTV4Gf+kOdf9+eb1AuBE6kw7/HiAfeG7f R/7sjnc2F4K/b2dQscGC8krbgAEbfpikibcKF9Vk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ping Cheng , Qasim Ijaz , Jiri Kosina Subject: [PATCH 5.4 046/148] HID: wacom: fix memory leak on kobject creation failure Date: Tue, 15 Jul 2025 15:12:48 +0200 Message-ID: <20250715130802.162295835@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qasim Ijaz commit 5ae416c5b1e2e816aee7b3fc8347adf70afabb4c upstream. During wacom_initialize_remotes() a fifo buffer is allocated with kfifo_alloc() and later a cleanup action is registered during devm_add_action_or_reset() to clean it up. However if the code fails to create a kobject and register it with sysfs the code simply returns -ENOMEM before the cleanup action is registered leading to a memory leak. Fix this by ensuring the fifo is freed when the kobject creation and registration process fails. Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated") Reviewed-by: Ping Cheng Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/wacom_sys.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2020,8 +2020,10 @@ static int wacom_initialize_remotes(stru remote->remote_dir = kobject_create_and_add("wacom_remote", &wacom->hdev->dev.kobj); - if (!remote->remote_dir) + if (!remote->remote_dir) { + kfifo_free(&remote->remote_fifo); return -ENOMEM; + } error = sysfs_create_files(remote->remote_dir, remote_unpair_attrs);