From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E612A2E3391; Tue, 15 Jul 2025 13:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586399; cv=none; b=fv3kpM6Rg8vtIg2q1l5yuZVOq9felmCBM232zgTUcRoxjt9L4DntA6fwtTWHeDCPCWxLiP94SmU5D2Czb61/YmtSGvm8tlLCEY/viCdonfqviAUC/l8h8ZS6W+svHXrWiVALVq3JE5AVc0U8WMd0LHcAzpw4DFU7rqNMjBfOpiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586399; c=relaxed/simple; bh=5ShqdG7csOlitq8plmC7EAIqAAdF24DfJrFOhjtpWYc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F0yRC/xAKNXUrshSXKbBZRqq27HXwmJZQZWjGJM8i3Tbnv+etUDX6zKtFuUXsY5S/MSJKMX9FByaakiTm7T/C9VBoMhWwOVS8Sl+5Sic/Ukcn8zaO0YYxKQUCyTCKLNAVch3m8CWAitFSGk7Bv2cofEzb1+4AeqcErQQkFHrLVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mNYvNJE2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mNYvNJE2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77B8DC4CEE3; Tue, 15 Jul 2025 13:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586398; bh=5ShqdG7csOlitq8plmC7EAIqAAdF24DfJrFOhjtpWYc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mNYvNJE2qwsvjO0I710Wx20AWMxQPb7BcckvOr7UcBsBVxsk+gNu0rg2dxJNjGmjb k2fojM5MjUto91P8zGWEFkCBQL48DWclZTy+JOqJTJPdn57XoI3pcgw6qK5mpbvvIw tZGXE8jNGcgWha53bUBRURNPDZYlGDxYEo2Nsz6w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Baryshkov , Tomi Valkeinen , Aradhya Bhatia , Aradhya Bhatia , Dmitry Baryshkov Subject: [PATCH 5.4 051/148] drm/bridge: cdns-dsi: Fix connecting to next bridge Date: Tue, 15 Jul 2025 15:12:53 +0200 Message-ID: <20250715130802.366474552@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aradhya Bhatia commit 688eb4d465484bc2a3471a6a6f06f833b58c7867 upstream. Fix the OF node pointer passed to the of_drm_find_bridge() call to find the next bridge in the display chain. The code to find the next panel (and create its panel-bridge) works fine, but to find the next (non-panel) bridge does not. To find the next bridge in the pipeline, we need to pass "np" - the OF node pointer of the next entity in the devicetree chain. Passing "of_node" to of_drm_find_bridge (which is what the code does currently) will fetch the bridge for the cdns-dsi which is not what's required. Fix that. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Cc: stable@vger.kernel.org Reviewed-by: Dmitry Baryshkov Reviewed-by: Tomi Valkeinen Tested-by: Tomi Valkeinen Signed-off-by: Aradhya Bhatia Signed-off-by: Aradhya Bhatia Link: https://lore.kernel.org/r/20250329113925.68204-2-aradhya.bhatia@linux.dev Signed-off-by: Dmitry Baryshkov Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/bridge/cdns-dsi.c +++ b/drivers/gpu/drm/bridge/cdns-dsi.c @@ -959,7 +959,7 @@ static int cdns_dsi_attach(struct mipi_d if (!IS_ERR(panel)) { bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DSI); } else { - bridge = of_drm_find_bridge(dev->dev.of_node); + bridge = of_drm_find_bridge(np); if (!bridge) bridge = ERR_PTR(-EINVAL); }