From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A65FF2E54B7; Tue, 15 Jul 2025 13:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586462; cv=none; b=anjG2QhzMLXxTsxEvJIdVIzFJZheA6oRofK5+uQsbn8NxN8KY2DmpadnXSEJdoRxoCbhFuKXl2df+pnISNb2G0l3P0Pb/jsUbBff2F6zv1dV8J9FYDISJZa9lCf/5Dvkn76CA1c0UG1So4qZiP0s1AkjsN7qiDrO+GJmOWmzGqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752586462; c=relaxed/simple; bh=VYa9cuxf8SK4g+LyRyvgJQyq6nKd6bd6KM24orC7YH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HibuFBlV3bqy5UKVfUgNoPHySAJpGsVtIDeUFR8t3R1CUgBEl14VtWHqc323UWzMdxk6MGuXdRqMV9hRkWObJUKRacEcNDrOoZEzOH60dYspjbWg/+F2NRvNhrH1QqYA8LqzfiIlv7uaulBKLvUJUI4n0kKUAAJE9WlhCTnCThs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=f36/urlj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="f36/urlj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B70AC4CEE3; Tue, 15 Jul 2025 13:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1752586462; bh=VYa9cuxf8SK4g+LyRyvgJQyq6nKd6bd6KM24orC7YH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f36/urljMgNVUAMqHuAWWoiGZ6LegRj2w255wNA26Kos0KpSeac6PIowk2T8XPNAr 3+kvMwXqij81Hey0GhnHxPKBIAStBAUY4t5KsvjPViIhsSoh5Id2+0p3LjxCOtZnKB oeRATxNjZHxMH+IcZW82OXMWn9KUlLH79/G/On0A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Dan Carpenter , Ido Schimmel , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 067/148] lib: test_objagg: Set error message in check_expect_hints_stats() Date: Tue, 15 Jul 2025 15:13:09 +0200 Message-ID: <20250715130803.010502404@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715130800.293690950@linuxfoundation.org> References: <20250715130800.293690950@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit e6ed134a4ef592fe1fd0cafac9683813b3c8f3e8 ] Smatch complains that the error message isn't set in the caller: lib/test_objagg.c:923 test_hints_case2() error: uninitialized symbol 'errmsg'. This static checker warning only showed up after a recent refactoring but the bug dates back to when the code was originally added. This likely doesn't affect anything in real life. Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202506281403.DsuyHFTZ-lkp@intel.com/ Fixes: 0a020d416d0a ("lib: introduce initial implementation of object aggregation manager") Signed-off-by: Dan Carpenter Reviewed-by: Ido Schimmel Reviewed-by: Simon Horman Link: https://patch.msgid.link/8548f423-2e3b-4bb7-b816-5041de2762aa@sabinyo.mountain Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- lib/test_objagg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/test_objagg.c b/lib/test_objagg.c index da137939a4100..78d25ab19a960 100644 --- a/lib/test_objagg.c +++ b/lib/test_objagg.c @@ -899,8 +899,10 @@ static int check_expect_hints_stats(struct objagg_hints *objagg_hints, int err; stats = objagg_hints_stats_get(objagg_hints); - if (IS_ERR(stats)) + if (IS_ERR(stats)) { + *errmsg = "objagg_hints_stats_get() failed."; return PTR_ERR(stats); + } err = __check_expect_stats(stats, expect_stats, errmsg); objagg_stats_put(stats); return err; -- 2.39.5