From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959AE1917E3; Tue, 22 Jul 2025 14:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753193051; cv=none; b=IWnAHUmn/Tsf9f1sN7Dv27Xr1gC34XSZ8jK6lokjCNRY2P+9DMygDURygxewdNoIM9LiNjJKKtOCG40QRfR/zAeyVdSnL+2EYhDoheca41Zqmr5zlkVTFmebY6GyBjjs+ksGxtFfecMfSZ6U/TBecCuVdY0VnRFAMZ56y8vQdoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753193051; c=relaxed/simple; bh=8Ty+9P22z0XOGhJJrkAMAaozONv+NNEMLfRGWf9WCm8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=leTsUR0R7op7ojIHVw6pRt1RhRE3lgWU2p6JM4m2bAN0DAC99VKAb8iBSc4xYZAE1bLtL/hwJPZgOXWn0Ip6K5Dwi/ID+/97T2IIs0EmffFlf7PBjEHPEHIA//FdCC/7fdwECeed2iicD1qZNVpFi3qmX5VkpLZI+zKl1pzJxC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Te/huN8G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Te/huN8G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCDC0C4CEF1; Tue, 22 Jul 2025 14:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1753193051; bh=8Ty+9P22z0XOGhJJrkAMAaozONv+NNEMLfRGWf9WCm8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Te/huN8G87foGo7Km1rAPZFSSeyeHd9dpo5lGp83jvfK48P928aBfmai3aSxkoOAr kPxdJs+lwBG+csDzWqPdPHSR1hTp53t7NcgmUZYtthOpYM5lxA6tSBayfDdk21DcFe IwQVAt9jaQnwB8Ztt8AhkkFQzgsx/G4TnifpksOA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Howells , Jeffrey Altman , Marc Dionne , "Junvyyang, Tencent Zhuque Lab" , LePremierHomme , Linus Torvalds , Simon Horman , linux-afs@lists.infradead.org, Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 134/158] rxrpc: Fix transmission of an abort in response to an abort Date: Tue, 22 Jul 2025 15:45:18 +0200 Message-ID: <20250722134345.727723346@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250722134340.596340262@linuxfoundation.org> References: <20250722134340.596340262@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Howells [ Upstream commit e9c0b96ec0a34fcacdf9365713578d83cecac34c ] Under some circumstances, such as when a server socket is closing, ABORT packets will be generated in response to incoming packets. Unfortunately, this also may include generating aborts in response to incoming aborts - which may cause a cycle. It appears this may be made possible by giving the client a multicast address. Fix this such that rxrpc_reject_packet() will refuse to generate aborts in response to aborts. Fixes: 248f219cb8bc ("rxrpc: Rewrite the data and ack handling code") Signed-off-by: David Howells Reviewed-by: Jeffrey Altman cc: Marc Dionne cc: Junvyyang, Tencent Zhuque Lab cc: LePremierHomme cc: Linus Torvalds cc: Simon Horman cc: linux-afs@lists.infradead.org Link: https://patch.msgid.link/20250717074350.3767366-5-dhowells@redhat.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/rxrpc/output.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index 5ea9601efd05a..ccfae607c9bb7 100644 --- a/net/rxrpc/output.c +++ b/net/rxrpc/output.c @@ -590,6 +590,9 @@ void rxrpc_reject_packet(struct rxrpc_local *local, struct sk_buff *skb) __be32 code; int ret, ioc; + if (sp->hdr.type == RXRPC_PACKET_TYPE_ABORT) + return; /* Never abort an abort. */ + rxrpc_see_skb(skb, rxrpc_skb_see_reject); iov[0].iov_base = &whdr; -- 2.39.5