From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FBAC156CA; Wed, 23 Jul 2025 00:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753232298; cv=none; b=A+Ep+WkZgtzWfbkI5k1lLGSiigVp5o7uu9uCxOwXtT0dIXhNHsBu6HO5MZYrYajXQ0WMxQzwWoZxXAOMVDO7AT9r7iGL7Sc6lOWvzpVHK5huRxriBqPVu/ixm6Lkf1wqHp2tpOlxlWPLTmj55rrQGSyyFSTT2+6jSCethaKqY44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753232298; c=relaxed/simple; bh=Khs2QSkLgbVPNayxxN+Z6xg0/3JqX2x8gNnr3tmstmQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=e4mbX7icyHuFTFXBm/xlHjYghc48pS3gesaJlqjwKrIRCl6WuoLKJJha7Qt5b+RCVreAb583k8eELrxt4YGifkOs4nfQMaOYjMCH+UZ3BWhtfLhxPkSysrwcAU9sDk7I+/d1lRS2vhB7dW51CDZQHGZOAGspIBFX6PREla7UEH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UUVZe7Ug; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UUVZe7Ug" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27EF9C4CEEB; Wed, 23 Jul 2025 00:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753232298; bh=Khs2QSkLgbVPNayxxN+Z6xg0/3JqX2x8gNnr3tmstmQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UUVZe7Ug3idbSx0xMqKEO9RS6hWMV0WXjtdARolVrzUFcJx8ycMBoAlM6zYk7PxBe z2AUBwSS70TGJI5VZ38jMvXbZtskgdM9WazS8xQ8NlCoaI8LP01Sbh3SKYllp3vqJ/ 8dt90i8uAdSXIPw0GRP7cXZKo2WSk3nuo9FO3wQdT59fv4SZCbWwInKU2pPcV3HPUl QPI2yCCGlWWImsOpo11PTBgtQQ5rr6NDDHrzFqH/Rn7w5W6W2xz6yneTHV94J8j78V 8Z9l18xT9Y60lr70nbMC6a8TD8j2SQ7quSa2r4CQRW+qcjISmkORJmrvUzqJ3o80LR 599wWyN3n4cvA== From: Sasha Levin To: patches@lists.linux.dev, stable@vger.kernel.org Cc: Adam Queler , Adam Queler , Mark Brown , Sasha Levin , venkataprasad.potturu@amd.com, tiwai@suse.de, mario.limonciello@amd.com, lachlan.hodges@morsemicro.com, talhah.peerbhai@gmail.com Subject: [PATCH AUTOSEL 6.12 3/6] ASoC: amd: yc: Add DMI entries to support HP 15-fb1xxx Date: Tue, 22 Jul 2025 20:57:59 -0400 Message-Id: <20250723005805.1023184-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250723005805.1023184-1-sashal@kernel.org> References: <20250723005805.1023184-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.39 Content-Transfer-Encoding: 8bit From: Adam Queler [ Upstream commit 949ddec3728f3a793a13c1c9003028b9b159aefc ] This model requires an additional detection quirk to enable the internal microphone. Signed-off-by: Adam Queler Link: https://patch.msgid.link/20250715031434.222062-1-queler+k@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- LLM Generated explanations, may be completely bogus: **YES** This commit should be backported to stable kernel trees. Here's my extensive analysis: ## Nature of the Change This commit adds a simple DMI (Desktop Management Interface) quirk entry for the HP Victus Gaming Laptop 15-fb1xxx model to enable internal microphone support. The change is: - Adding a new entry to the `yc_acp_quirk_table[]` array - The entry matches DMI_BOARD_VENDOR "HP" and DMI_PRODUCT_NAME "Victus by HP Gaming Laptop 15-fb1xxx" - Associates the match with `&acp6x_card` driver data ## Comparison with Similar Commits All 5 similar commits with "Backport Status: YES" follow the exact same pattern: 1. They add DMI entries for HP laptops (HP OMEN, HP Victus) or other brands 2. They enable internal microphone functionality for specific hardware models 3. They are minimal, self-contained changes adding only DMI match entries 4. They fix hardware enablement issues that affect users ## Backport Suitability Analysis **Reasons this qualifies for stable backporting:** 1. **Bug Fix**: This fixes a hardware functionality issue where the internal microphone doesn't work on HP Victus 15-fb1xxx laptops without this quirk 2. **User Impact**: Without this patch, users of this specific laptop model cannot use their internal microphone, which is a significant functionality regression 3. **Minimal Risk**: The change is: - Extremely localized (only adds one DMI entry) - Cannot affect other hardware (DMI matching is specific to this model) - Uses the same pattern as dozens of other entries in the same table - No algorithmic changes or new features 4. **Self-Contained**: The patch is completely self-contained with no dependencies on other changes 5. **Hardware Enablement**: This falls under the stable tree criteria for "hardware that is broken by design and needs a quirk" 6. **Precedent**: The git history shows numerous similar DMI quirk additions for this driver have been backported to stable ## Code Safety Analysis The code change is safe because: - It only adds a static data structure entry - The DMI matching system is well-established and reliable - The `acp6x_card` driver data is already used by many other entries - No memory allocations, no new logic paths, no behavioral changes for existing hardware This is a textbook example of a stable-appropriate patch: it fixes a real user-facing bug with minimal risk and follows established patterns. sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index 42d123cb8b4c6..4bde41663f421 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -528,6 +528,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "Victus by HP Gaming Laptop 15-fb1xxx"), + } + }, { .driver_data = &acp6x_card, .matches = { -- 2.39.5