From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Alexandru Andries <alex.andries.aa@gmail.com>,
Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
venkataprasad.potturu@amd.com, mario.limonciello@amd.com,
tiwai@suse.de, lachlan.hodges@morsemicro.com,
talhah.peerbhai@gmail.com
Subject: [PATCH AUTOSEL 6.12 6/6] ASoC: amd: yc: add DMI quirk for ASUS M6501RM
Date: Tue, 22 Jul 2025 20:58:02 -0400 [thread overview]
Message-ID: <20250723005805.1023184-6-sashal@kernel.org> (raw)
In-Reply-To: <20250723005805.1023184-1-sashal@kernel.org>
From: Alexandru Andries <alex.andries.aa@gmail.com>
[ Upstream commit 6f80be548588429100eb1f5e25dc2a714d583ffe ]
add DMI entry for ASUS Vivobook PRO 15X (M6501RM)
to make the internal microphone function
Signed-off-by: Alexandru Andries <alex.andries.aa@gmail.com>
Link: https://patch.msgid.link/20250707220730.361290-1-alex.andries.aa@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
**YES**
This commit should be backported to stable kernel trees. Here's my
extensive analysis:
## Analysis of the Commit
### 1. **Nature of the Change**
The commit adds a DMI (Desktop Management Interface) quirk entry for the
ASUS Vivobook PRO 15X (M6501RM) laptop to enable its internal microphone
functionality. The change is minimal - it simply adds 7 lines to the
`yc_acp_quirk_table[]` array in `sound/soc/amd/yc/acp6x-mach.c`:
```c
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER
INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "M6501RM"),
+ }
+ },
```
### 2. **Impact and Bug Fix Nature**
This is a classic hardware enablement fix that:
- **Fixes a real user-facing bug**: The internal microphone on this
specific laptop model doesn't work without this quirk
- **Has zero functional impact on other systems**: DMI quirks only
activate when the exact hardware match is found
- **Follows an established pattern**: The file contains dozens of
similar DMI quirks for various laptop models
### 3. **Code Context Analysis**
From examining the kernel repository:
- The `yc_acp_quirk_table[]` is used in the `acp6x_probe()` function to
enable DMIC (Digital Microphone) support for AMD Yellow Carp platform
- The driver first tries ACPI methods to detect DMIC capability, but
falls back to DMI quirks for systems that don't properly advertise
this capability
- Without this quirk, the microphone simply won't be detected or
function on the affected laptop model
### 4. **Comparison with Similar Commits**
Looking at the historical patterns:
- **3 out of 5 similar DMI quirk additions were marked for stable**
(commits with "Cc: stable@vger.kernel.org")
- All commits marked "YES" for backporting share these characteristics:
- Fix microphone functionality issues
- Add simple DMI entries
- Have bug reports or user confirmations
- Minimal risk of regression
### 5. **Stable Tree Criteria Evaluation**
This commit meets all the key stable tree criteria:
- ✅ **Fixes a real bug**: Broken microphone functionality
- ✅ **Small and contained**: Only 7 lines added
- ✅ **No side effects**: Only affects the specific laptop model
- ✅ **No architectural changes**: Simple table entry addition
- ✅ **Minimal regression risk**: Cannot affect other hardware
- ✅ **User-reported issue**: Commit message indicates user need
### 6. **Risk Assessment**
The risk is essentially zero because:
- DMI matching is exact - it requires both vendor and product name to
match
- The quirk only enables existing functionality, doesn't modify behavior
- Similar quirks have been added hundreds of times without issues
- The pattern is well-established in this subsystem
### 7. **Additional Considerations**
While this commit doesn't have an explicit "Cc: stable@vger.kernel.org"
tag, this is not unusual for AMD audio quirks. The maintainers often
rely on stable maintainers to pick up these obvious hardware enablement
fixes based on their merit.
This type of hardware enablement fix is exactly what stable kernels
should include - it makes Linux work properly on real hardware that
users have purchased, without any risk to existing functionality.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 4bde41663f421..e362c2865ec13 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -409,6 +409,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "M6500RC"),
}
},
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "M6501RM"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
--
2.39.5
prev parent reply other threads:[~2025-07-23 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 0:57 [PATCH AUTOSEL 6.12 1/6] ASoC: amd: yc: Add DMI quirk for HP Laptop 17 cp-2033dx Sasha Levin
2025-07-23 0:57 ` [PATCH AUTOSEL 6.12 2/6] ethernet: intel: fix building with large NR_CPUS Sasha Levin
2025-07-23 0:57 ` [PATCH AUTOSEL 6.12 3/6] ASoC: amd: yc: Add DMI entries to support HP 15-fb1xxx Sasha Levin
2025-07-23 0:58 ` [PATCH AUTOSEL 6.12 4/6] ALSA: hda/cs35l56: Workaround bad dev-index on Lenovo Yoga Book 9i GenX Sasha Levin
2025-07-23 0:58 ` [PATCH AUTOSEL 6.12 5/6] ASoC: Intel: fix SND_SOC_SOF dependencies Sasha Levin
2025-07-23 0:58 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723005805.1023184-6-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=alex.andries.aa@gmail.com \
--cc=broonie@kernel.org \
--cc=lachlan.hodges@morsemicro.com \
--cc=mario.limonciello@amd.com \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=talhah.peerbhai@gmail.com \
--cc=tiwai@suse.de \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).