patches.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Adam Queler <queler@gmail.com>, Adam Queler <queler+k@gmail.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
	tiwai@suse.de, venkataprasad.potturu@amd.com,
	mario.limonciello@amd.com, lachlan.hodges@morsemicro.com,
	talhah.peerbhai@gmail.com
Subject: [PATCH AUTOSEL 6.1 2/3] ASoC: amd: yc: Add DMI entries to support HP 15-fb1xxx
Date: Tue, 22 Jul 2025 20:58:56 -0400	[thread overview]
Message-ID: <20250723005857.1023488-2-sashal@kernel.org> (raw)
In-Reply-To: <20250723005857.1023488-1-sashal@kernel.org>

From: Adam Queler <queler@gmail.com>

[ Upstream commit 949ddec3728f3a793a13c1c9003028b9b159aefc ]

This model requires an additional detection quirk to
enable the internal microphone.

Signed-off-by: Adam Queler <queler+k@gmail.com>
Link: https://patch.msgid.link/20250715031434.222062-1-queler+k@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

**YES**

This commit should be backported to stable kernel trees. Here's my
extensive analysis:

## Nature of the Change

This commit adds a simple DMI (Desktop Management Interface) quirk entry
for the HP Victus Gaming Laptop 15-fb1xxx model to enable internal
microphone support. The change is:
- Adding a new entry to the `yc_acp_quirk_table[]` array
- The entry matches DMI_BOARD_VENDOR "HP" and DMI_PRODUCT_NAME "Victus
  by HP Gaming Laptop 15-fb1xxx"
- Associates the match with `&acp6x_card` driver data

## Comparison with Similar Commits

All 5 similar commits with "Backport Status: YES" follow the exact same
pattern:
1. They add DMI entries for HP laptops (HP OMEN, HP Victus) or other
   brands
2. They enable internal microphone functionality for specific hardware
   models
3. They are minimal, self-contained changes adding only DMI match
   entries
4. They fix hardware enablement issues that affect users

## Backport Suitability Analysis

**Reasons this qualifies for stable backporting:**

1. **Bug Fix**: This fixes a hardware functionality issue where the
   internal microphone doesn't work on HP Victus 15-fb1xxx laptops
   without this quirk

2. **User Impact**: Without this patch, users of this specific laptop
   model cannot use their internal microphone, which is a significant
   functionality regression

3. **Minimal Risk**: The change is:
   - Extremely localized (only adds one DMI entry)
   - Cannot affect other hardware (DMI matching is specific to this
     model)
   - Uses the same pattern as dozens of other entries in the same table
   - No algorithmic changes or new features

4. **Self-Contained**: The patch is completely self-contained with no
   dependencies on other changes

5. **Hardware Enablement**: This falls under the stable tree criteria
   for "hardware that is broken by design and needs a quirk"

6. **Precedent**: The git history shows numerous similar DMI quirk
   additions for this driver have been backported to stable

## Code Safety Analysis

The code change is safe because:
- It only adds a static data structure entry
- The DMI matching system is well-established and reliable
- The `acp6x_card` driver data is already used by many other entries
- No memory allocations, no new logic paths, no behavioral changes for
  existing hardware

This is a textbook example of a stable-appropriate patch: it fixes a
real user-facing bug with minimal risk and follows established patterns.

 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1f4c43bf817e4..fce918a089e37 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -458,6 +458,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "OMEN by HP Gaming Laptop 16z-n000"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "HP"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Victus by HP Gaming Laptop 15-fb1xxx"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.39.5


  reply	other threads:[~2025-07-23  0:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23  0:58 [PATCH AUTOSEL 6.1 1/3] ethernet: intel: fix building with large NR_CPUS Sasha Levin
2025-07-23  0:58 ` Sasha Levin [this message]
2025-07-23  0:58 ` [PATCH AUTOSEL 6.1 3/3] ASoC: Intel: fix SND_SOC_SOF dependencies Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250723005857.1023488-2-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lachlan.hodges@morsemicro.com \
    --cc=mario.limonciello@amd.com \
    --cc=patches@lists.linux.dev \
    --cc=queler+k@gmail.com \
    --cc=queler@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=talhah.peerbhai@gmail.com \
    --cc=tiwai@suse.de \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).