From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Breno Leitao <leitao@debian.org>, Tony Luck <tony.luck@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Sasha Levin <sashal@kernel.org>,
rafael@kernel.org, ira.weiny@intel.com, dave.jiang@intel.com,
xueshuai@linux.alibaba.com,
Smita.KoralahalliChannabasappa@amd.com, peterz@infradead.org,
bp@alien8.de, linux-acpi@vger.kernel.org
Subject: [PATCH AUTOSEL 5.15 26/44] ACPI: APEI: GHES: add TAINT_MACHINE_CHECK on GHES panic path
Date: Sun, 3 Aug 2025 20:38:31 -0400 [thread overview]
Message-ID: <20250804003849.3627024-26-sashal@kernel.org> (raw)
In-Reply-To: <20250804003849.3627024-1-sashal@kernel.org>
From: Breno Leitao <leitao@debian.org>
[ Upstream commit 4734c8b46b901cff2feda8b82abc710b65dc31c1 ]
When a GHES (Generic Hardware Error Source) triggers a panic, add the
TAINT_MACHINE_CHECK taint flag to the kernel. This explicitly marks the
kernel as tainted due to a machine check event, improving diagnostics
and post-mortem analysis. The taint is set with LOCKDEP_STILL_OK to
indicate lockdep remains valid.
At large scale deployment, this helps to quickly determine panics that
are coming due to hardware failures.
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Link: https://patch.msgid.link/20250702-add_tain-v1-1-9187b10914b9@debian.org
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
Based on my analysis of this commit, here is my assessment:
**Backport Status: YES**
This commit should be backported to stable kernel trees for the
following reasons:
1. **Fixes a real diagnostic issue**: The commit adds the
TAINT_MACHINE_CHECK flag when GHES (Generic Hardware Error Source)
triggers a panic. This is important for post-mortem analysis at
scale, as explicitly stated in the commit message: "At large scale
deployment, this helps to quickly determine panics that are coming
due to hardware failures."
2. **Small and contained change**: The patch adds only a single line of
code (`add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);`) in the
`__ghes_panic()` function at drivers/acpi/apei/ghes.c:1091. This
meets the stable kernel rule of being under 100 lines.
3. **Obviously correct**: The change follows established kernel
patterns. Looking at the grep results, other machine check handlers
already use this same pattern:
- arch/x86/kernel/cpu/mce/core.c:1640
- arch/powerpc/kernel/mce.c:332
- arch/x86/kernel/cpu/mce/p5.c:40
- arch/x86/kernel/cpu/mce/winchip.c:24
4. **No architectural changes**: This is purely a diagnostic improvement
that adds taint information without changing any functionality or
behavior of the GHES panic path.
5. **Minimal risk**: The change uses LOCKDEP_STILL_OK flag, indicating
that lockdep remains valid after the taint, which is the safer option
compared to LOCKDEP_NOW_UNRELIABLE used in some other machine check
paths.
6. **Real benefit for users**: For organizations running Linux at scale,
being able to quickly identify hardware-related panics through the
taint flag provides significant operational value for triaging
issues.
The commit meets all the stable kernel criteria: it's small, obviously
correct, fixes a real diagnostic limitation that affects users
(especially at scale), and has been reviewed by Tony Luck who is a
recognized maintainer in the RAS (Reliability, Availability, and
Serviceability) subsystem.
drivers/acpi/apei/ghes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 72087e05b5a5..250ea9ec5f0c 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -860,6 +860,8 @@ static void __ghes_panic(struct ghes *ghes,
__ghes_print_estatus(KERN_EMERG, ghes->generic, estatus);
+ add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
+
ghes_clear_estatus(ghes, estatus, buf_paddr, fixmap_idx);
if (!panic_timeout)
--
2.39.5
next prev parent reply other threads:[~2025-08-04 0:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 0:38 [PATCH AUTOSEL 5.15 01/44] usb: xhci: print xhci->xhc_state when queue_command failed Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 02/44] cpufreq: CPPC: Mark driver with NEED_UPDATE_LIMITS flag Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 03/44] selftests/futex: Define SYS_futex on 32-bit architectures with 64-bit time_t Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 04/44] usb: typec: ucsi: psy: Set current max to 100mA for BC 1.2 and Default Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 05/44] regulator: core: repeat voltage setting request for stepped regulators Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 06/44] usb: xhci: Avoid showing warnings for dying controller Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 07/44] usb: xhci: Set avg_trb_len = 8 for EP0 during Address Device Command Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 08/44] usb: xhci: Avoid showing errors during surprise removal Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 09/44] gpio: wcd934x: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 10/44] cpufreq: Exit governor when failed to start old governor Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 11/44] ARM: rockchip: fix kernel hang during smp initialization Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 12/44] PM / devfreq: governor: Replace sscanf() with kstrtoul() in set_freq_store() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 13/44] EDAC/synopsys: Clear the ECC counters on init Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 14/44] ASoC: soc-dapm: set bias_level if snd_soc_dapm_set_bias_level() was successed Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 15/44] thermal/drivers/qcom-spmi-temp-alarm: Enable stage 2 shutdown when required Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 16/44] tools/nolibc: define time_t in terms of __kernel_old_time_t Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 17/44] gpio: tps65912: check the return value of regmap_update_bits() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 18/44] ARM: tegra: Use I/O memcpy to write to IRAM Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 19/44] selftests: tracing: Use mutex_unlock for testing glob filter Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 20/44] ACPI: PRM: Reduce unnecessary printing to avoid user confusion Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 21/44] PM: runtime: Clear power.needs_force_resume in pm_runtime_reinit() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 22/44] thermal: sysfs: Return ENODATA instead of EAGAIN for reads Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 23/44] PM: sleep: console: Fix the black screen issue Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 24/44] ACPI: processor: fix acpi_object initialization Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 25/44] mmc: sdhci-msm: Ensure SD card power isn't ON when card removed Sasha Levin
2025-08-04 0:38 ` Sasha Levin [this message]
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 27/44] pps: clients: gpio: fix interrupt handling order in remove path Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 28/44] reset: brcmstb: Enable reset drivers for ARCH_BCM2835 Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 29/44] mmc: rtsx_usb_sdmmc: Fix error-path in sd_set_power_mode() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 30/44] x86/bugs: Avoid warning when overriding return thunk Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 31/44] ASoC: hdac_hdmi: Rate limit logging on connection and disconnection Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 32/44] ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4 Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 33/44] ASoC: core: Check for rtd == NULL in snd_soc_remove_pcm_runtime() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 34/44] usb: typec: intel_pmc_mux: Defer probe if SCU IPC isn't present Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 35/44] usb: core: usb_submit_urb: downgrade type check Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 36/44] usb: typec: fusb302: fix scheduling while atomic when using virtio-gpio Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 37/44] pm: cpupower: Fix the snapshot-order of tsc,mperf, clock in mperf_stop() Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 38/44] platform/x86: thinkpad_acpi: Handle KCOV __init vs inline mismatches Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 39/44] platform/chrome: cros_ec_typec: Defer probe on missing EC parent Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 40/44] ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 41/44] ALSA: pcm: Rewrite recalculate_boundary() to avoid costly loop Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 42/44] ALSA: usb-audio: Avoid precedence issues in mixer_quirks macros Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 43/44] iio: adc: ad7768-1: Ensure SYNC_IN pulse minimum timing requirement Sasha Levin
2025-08-04 0:38 ` [PATCH AUTOSEL 5.15 44/44] ASoC: codecs: rt5640: Retry DEVICE_ID verification Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804003849.3627024-26-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=leitao@debian.org \
--cc=linux-acpi@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox