From: Kundan Kumar <kundan.kumar@samsung.com>
To: mcgrof@kernel.org
Cc: patches@lists.linux.dev, Kundan Kumar <kundan.kumar@samsung.com>,
Anuj Gupta <anuj20.g@samsung.com>
Subject: [PATCH v2 15/15] writeback: added support to change the number of writebacks using a sysfs attribute
Date: Thu, 7 Aug 2025 10:27:06 +0530 [thread overview]
Message-ID: <20250807045706.2848-16-kundan.kumar@samsung.com> (raw)
In-Reply-To: <20250807045706.2848-1-kundan.kumar@samsung.com>
User can change the number of writeback contexts with values 1 to num
cpus using the new sysfs attribute
echo <num_writbacks> > /sys/class/bdi/<maj>:<min>/nwritebacks
The sequence of operations when number of writebacks is changed :
- fetch the superblock for a bdi
- freezes the filesystem
- iterate through inodes of the superblock and flush the pages
- shutdown and free the writeback threads
- allocate and registter the wb threads
- thaw the filesystem
Signed-off-by: Kundan Kumar <kundan.kumar@samsung.com>
Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
---
fs/super.c | 23 +++++++++
include/linux/backing-dev.h | 1 +
include/linux/fs.h | 1 +
mm/backing-dev.c | 93 +++++++++++++++++++++++++++++++++++++
mm/page-writeback.c | 8 ++++
5 files changed, 126 insertions(+)
diff --git a/fs/super.c b/fs/super.c
index 80418ca8e215..097d10e69e18 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -2061,6 +2061,29 @@ static inline bool may_unfreeze(struct super_block *sb, enum freeze_holder who,
return false;
}
+struct super_block *freeze_bdi_super(struct backing_dev_info *bdi)
+{
+ struct super_block *sb_iter;
+ struct super_block *sb = NULL;
+
+ spin_lock(&sb_lock);
+ list_for_each_entry(sb_iter, &super_blocks, s_list) {
+ if (sb_iter->s_bdi == bdi) {
+ sb = sb_iter;
+ break;
+ }
+ }
+ spin_unlock(&sb_lock);
+
+ if (sb) {
+ atomic_inc(&sb->s_active);
+ freeze_super(sb, FREEZE_HOLDER_KERNEL, NULL);
+ }
+
+ return sb;
+}
+EXPORT_SYMBOL(freeze_bdi_super);
+
/**
* freeze_super - lock the filesystem and force it into a consistent state
* @sb: the super to lock
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 5ed8294e0c0e..9c2d70d65277 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -145,6 +145,7 @@ int bdi_set_max_ratio_no_scale(struct backing_dev_info *bdi, unsigned int max_ra
int bdi_set_min_bytes(struct backing_dev_info *bdi, u64 min_bytes);
int bdi_set_max_bytes(struct backing_dev_info *bdi, u64 max_bytes);
int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit);
+int bdi_set_nwritebacks(struct backing_dev_info *bdi, unsigned int nwritebacks);
/*
* Flags in backing_dev_info::capability
diff --git a/include/linux/fs.h b/include/linux/fs.h
index edcbc5042427..f82f7ff2381f 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2758,6 +2758,7 @@ extern int unregister_filesystem(struct file_system_type *);
extern int vfs_statfs(const struct path *, struct kstatfs *);
extern int user_statfs(const char __user *, struct kstatfs *);
extern int fd_statfs(int, struct kstatfs *);
+struct super_block *freeze_bdi_super(struct backing_dev_info *bdi);
int freeze_super(struct super_block *super, enum freeze_holder who,
const void *freeze_owner);
int thaw_super(struct super_block *super, enum freeze_holder who,
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 392a4eb4a878..4de1a741cd57 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -35,6 +35,17 @@ LIST_HEAD(bdi_list);
/* bdi_wq serves all asynchronous writeback tasks */
struct workqueue_struct *bdi_wq;
+static int cgwb_bdi_init(struct backing_dev_info *bdi);
+static void cgwb_bdi_register(struct backing_dev_info *bdi,
+ struct bdi_writeback_ctx *bdi_wb_ctx);
+static void cgwb_bdi_unregister(struct backing_dev_info *bdi,
+ struct bdi_writeback_ctx *bdi_wb_ctx);
+static void wb_shutdown(struct bdi_writeback *wb);
+static void wb_exit(struct bdi_writeback *wb);
+static struct bdi_writeback_ctx **wb_ctx_alloc(struct backing_dev_info *bdi,
+ int num_ctxs);
+static void wb_ctx_free(struct backing_dev_info *bdi);
+
#ifdef CONFIG_DEBUG_FS
#include <linux/debugfs.h>
#include <linux/seq_file.h>
@@ -469,6 +480,87 @@ static ssize_t strict_limit_show(struct device *dev,
}
static DEVICE_ATTR_RW(strict_limit);
+static ssize_t nwritebacks_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+ unsigned int nwritebacks;
+ ssize_t ret;
+ struct super_block *sb = NULL;
+ struct bdi_writeback_ctx **wb_ctx;
+ struct bdi_writeback_ctx *bdi_wb_ctx;
+ struct inode *inode;
+
+ ret = kstrtouint(buf, 10, &nwritebacks);
+ if (ret < 0)
+ return ret;
+
+ if (nwritebacks < 1 || nwritebacks > num_online_cpus())
+ return -EINVAL;
+
+ if (nwritebacks == bdi->nr_wb_ctx)
+ return count;
+
+ wb_ctx = wb_ctx_alloc(bdi, nwritebacks);
+ if (!wb_ctx)
+ return -ENOMEM;
+
+ sb = freeze_bdi_super(bdi);
+ if (!sb)
+ return -EBUSY;
+
+ spin_lock(&sb->s_inode_list_lock);
+ list_for_each_entry(inode, &sb->s_inodes, i_sb_list) {
+ filemap_write_and_wait(inode->i_mapping);
+ truncate_inode_pages_final(inode->i_mapping);
+#ifdef CONFIG_CGROUP_WRITEBACK
+ if (inode->i_wb) {
+ WARN_ON_ONCE(!(inode->i_state & I_CLEAR));
+ wb_put(inode->i_wb);
+ inode->i_wb = NULL;
+ }
+#endif
+ }
+ spin_unlock(&sb->s_inode_list_lock);
+
+ for_each_bdi_wb_ctx(bdi, bdi_wb_ctx) {
+ wb_shutdown(&bdi_wb_ctx->wb);
+ cgwb_bdi_unregister(bdi, bdi_wb_ctx);
+ }
+
+ for_each_bdi_wb_ctx(bdi, bdi_wb_ctx) {
+ WARN_ON_ONCE(test_bit(WB_registered, &bdi_wb_ctx->wb.state));
+ wb_exit(&bdi_wb_ctx->wb);
+ kfree(bdi_wb_ctx);
+ }
+ kfree(bdi->wb_ctx);
+
+ ret = bdi_set_nwritebacks(bdi, nwritebacks);
+
+ bdi->wb_ctx = wb_ctx;
+
+ cgwb_bdi_init(bdi);
+ for_each_bdi_wb_ctx(bdi, bdi_wb_ctx) {
+ cgwb_bdi_register(bdi, bdi_wb_ctx);
+ set_bit(WB_registered, &bdi_wb_ctx->wb.state);
+ }
+
+ thaw_super(sb, FREEZE_HOLDER_KERNEL, NULL);
+ deactivate_super(sb);
+
+ return ret;
+}
+
+static ssize_t nwritebacks_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct backing_dev_info *bdi = dev_get_drvdata(dev);
+
+ return sysfs_emit(buf, "%d\n", bdi->nr_wb_ctx);
+}
+static DEVICE_ATTR_RW(nwritebacks);
+
static struct attribute *bdi_dev_attrs[] = {
&dev_attr_read_ahead_kb.attr,
&dev_attr_min_ratio.attr,
@@ -479,6 +571,7 @@ static struct attribute *bdi_dev_attrs[] = {
&dev_attr_max_bytes.attr,
&dev_attr_stable_pages_required.attr,
&dev_attr_strict_limit.attr,
+ &dev_attr_nwritebacks.attr,
NULL,
};
ATTRIBUTE_GROUPS(bdi_dev);
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 8b4271e75f9e..a28845d0171a 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -818,6 +818,14 @@ int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit
return 0;
}
+int bdi_set_nwritebacks(struct backing_dev_info *bdi, unsigned int nwritebacks)
+{
+ spin_lock_bh(&bdi_lock);
+ bdi->nr_wb_ctx = nwritebacks;
+ spin_unlock_bh(&bdi_lock);
+ return 0;
+}
+
static unsigned long dirty_freerun_ceiling(unsigned long thresh,
unsigned long bg_thresh)
{
--
2.25.1
next prev parent reply other threads:[~2025-08-07 4:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250807045740epcas5p4cdec49f07b86acf2eea832890393d256@epcas5p4.samsung.com>
2025-08-07 4:56 ` [PATCH v2 00/15] Test patch Parallelizing filesystem writeback Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 01/15] writeback: add infra for parallel writeback Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 02/15] writeback: add support to initialize and free multiple writeback ctxs Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 03/15] writeback: link bdi_writeback to its corresponding bdi_writeback_ctx Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 04/15] writeback: affine inode to a writeback ctx within a bdi Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 05/15] writeback: modify bdi_writeback search logic to search across all wb ctxs Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 06/15] writeback: invoke all writeback contexts for flusher and dirtytime writeback Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 07/15] writeback: modify sync related functions to iterate over all writeback contexts Kundan Kumar
2025-08-07 4:56 ` [PATCH v2 08/15] writeback: add support to collect stats for all writeback ctxs Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 09/15] f2fs: add support in f2fs to handle multiple writeback contexts Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 10/15] fuse: add support for multiple writeback contexts in fuse Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 11/15] gfs2: add support in gfs2 to handle multiple writeback contexts Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 12/15] nfs: add support in nfs " Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 13/15] writeback: set the num of writeback contexts to number of online cpus Kundan Kumar
2025-08-07 4:57 ` [PATCH v2 14/15] writeback: segregated allocation and free of writeback contexts Kundan Kumar
2025-08-07 4:57 ` Kundan Kumar [this message]
2025-08-07 18:34 ` [PATCH v2 00/15] Test patch Parallelizing filesystem writeback Luis Chamberlain
[not found] <CGME20250725155511epcas5p2498b51a3391fa4a8cf0354d6966686ac@epcas5p2.samsung.com>
2025-07-25 15:54 ` [PATCH v2 00/15] " Kundan Kumar
2025-07-25 15:54 ` [PATCH v2 15/15] writeback: added support to change the number of writebacks using a sysfs attribute Kundan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807045706.2848-16-kundan.kumar@samsung.com \
--to=kundan.kumar@samsung.com \
--cc=anuj20.g@samsung.com \
--cc=mcgrof@kernel.org \
--cc=patches@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox