From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8446E2F83CB; Tue, 12 Aug 2025 17:44:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020647; cv=none; b=XK5EXgdWIlahPfHevq7lktYuVHu6HweqVrNoCGWFSzDplZ89hVNDdi195hfFm6ht5GKrpVVJ/9DalpXRiCellaa7q4EskmvQAw1KNjZ053Yn+NW8L2/Ib7t3fnrt/Nn+DD22bji/a2WbQBuUJd2gY1alAzM2TpYYaM6WpjhxXKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755020647; c=relaxed/simple; bh=SAc41kHpOOqopMIcGvBGbHDsLm/Nxy78E7k53eGjJOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g965vXG0gM3eeaqtxZF/t3+ShfYAg84CA0y1DmeNdP0KXN5n1ZnUu6BJHuRjzXdpKe0Lkx/w5B2YrkUTC3+vfB0VFcTp5zin+nCgP+qeKU+Wd/M0zmHNK9WeYnRtzLqpoXSkxc+p5jLZLiGokkbb7GSTI5E5mOgLeRuIBhCmY9Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CtqGIcB/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CtqGIcB/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8602C4CEF0; Tue, 12 Aug 2025 17:44:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755020647; bh=SAc41kHpOOqopMIcGvBGbHDsLm/Nxy78E7k53eGjJOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CtqGIcB/zNKwUVUPCg3QjExHZ4bJjYX4/fifp0JUuNE+Z6PrBLI8Mu4iZdaKTLMpk 8iokKQCQokl/YqhBpdJil/ZzYF8Niu6HCl9+gsGnNeptSNKmp7y0osTDO6VCENj1sg HHoHhXGFnOqd75ZFk50fwE+WLoJuZQTk6ymvXMd4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ivan Stepchenko , Miquel Raynal , Sasha Levin Subject: [PATCH 6.1 142/253] mtd: fix possible integer overflow in erase_xfer() Date: Tue, 12 Aug 2025 19:28:50 +0200 Message-ID: <20250812172954.732384566@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172948.675299901@linuxfoundation.org> References: <20250812172948.675299901@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ivan Stepchenko [ Upstream commit 9358bdb9f9f54d94ceafc650deffefd737d19fdd ] The expression '1 << EraseUnitSize' is evaluated in int, which causes a negative result when shifting by 31 - the upper bound of the valid range [10, 31], enforced by scan_header(). This leads to incorrect extension when storing the result in 'erase->len' (uint64_t), producing a large unexpected value. Found by Linux Verification Center (linuxtesting.org) with Svace. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ivan Stepchenko Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/ftl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c index 8c22064ead38..f2bd1984609c 100644 --- a/drivers/mtd/ftl.c +++ b/drivers/mtd/ftl.c @@ -344,7 +344,7 @@ static int erase_xfer(partition_t *part, return -ENOMEM; erase->addr = xfer->Offset; - erase->len = 1 << part->header.EraseUnitSize; + erase->len = 1ULL << part->header.EraseUnitSize; ret = mtd_erase(part->mbd.mtd, erase); if (!ret) { -- 2.39.5