From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99EA52868AF; Tue, 12 Aug 2025 17:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021102; cv=none; b=K8fvlaTL2NfcJrjtK3MlC81CpiOqZ+7CWljTU76HABcxneEQQxSMdlgdtLXgG7b/+7I/yifobNAFxHXXNuQfGFfa6QgOW0BVEOjTqUutAv91d7ckDnB+tRP+qUKBuffH2AlRXMT241Kw8Xp83yWoNfzmp5mfRvltB2GbK2pHrlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021102; c=relaxed/simple; bh=BmYYfg/WYojZkjrC9SfyNMYDdqDR+PQ0IINYQt2Qs7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kr/TWvUidFMj5yuVDogfhewEAozN7lMicgrqNvd/nN2q2M2NLcf5qSjQcfsPnUThSZJZ/emRBbxllXMbuRdRzF0E45dpFQmymeiSVQnLKpbR2z+7VzRw84S7Kqy2dZZOvIrNgy4R7Hbu7SJAoG7Xtqn5piEMBVTB2mfsynKwFNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uNaI5fAu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uNaI5fAu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D74C2C4CEF7; Tue, 12 Aug 2025 17:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755021102; bh=BmYYfg/WYojZkjrC9SfyNMYDdqDR+PQ0IINYQt2Qs7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNaI5fAu5n/3fdrVWJtWjzm/8ghbvu1YkZ0Q6TJpvbqlVHW5V6v39rdnQ57VFOLDB FdhnT040L2zxdYInXiTQui3fF6Y/+eIfZy23QG9smYmyd6VvLKHRRro4PzkPiq7F+c xwZ8me2kjmiTMNcj1vaDFQpPsF/UwV2tTeSm5oEE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brian Masney , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.1 189/253] rtc: pcf85063: fix incorrect maximum clock rate handling Date: Tue, 12 Aug 2025 19:29:37 +0200 Message-ID: <20250812172956.839311039@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172948.675299901@linuxfoundation.org> References: <20250812172948.675299901@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brian Masney [ Upstream commit 186ae1869880e58bb3f142d222abdb35ecb4df0f ] When pcf85063_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 8c229ab6048b7 ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework") Signed-off-by: Brian Masney Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-4-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pcf85063.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 4a29b44e75e6..b095663d5ebc 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -410,7 +410,7 @@ static long pcf85063_clkout_round_rate(struct clk_hw *hw, unsigned long rate, if (clkout_rates[i] <= rate) return clkout_rates[i]; - return 0; + return clkout_rates[0]; } static int pcf85063_clkout_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.39.5