From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E125C2FDC25; Tue, 12 Aug 2025 17:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021499; cv=none; b=m57OVCprWdtMFHDvwKKqgIJkyadZ4IdaBiD9WnLlptgTsNCIeKQaYNOZmTtwfIl0S5vSy6+VKMkEyV0rHNe2pR6CEvFsJNscTKgpi8DZE3cxw+VIVHW4R0wjEMuqBiwoZ0Ta/NXuPFV4hE5pXur92egcbguGwFs9IGvjXQOt48s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021499; c=relaxed/simple; bh=OVQqARKx6ZDtd1kLGkTMLApCTYPSyv37BKP1AQFL20c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhLy48irh1x17x1tSq42e1jLmHrLuKYAGmFf2EcvfDJOpvRuTTQWODnEmLACdd86g21TxgG5Vcf1sGNgLQBpPP6KCfem55UGzwnCU7UUfWSThE1kh1lI0+pvDiEyoN0aIrLPcs5saaMOgSmCFprN56M+vHQw6FZpkq2UEHerelw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IaH6z6Jw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IaH6z6Jw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B0F4C4CEF0; Tue, 12 Aug 2025 17:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755021498; bh=OVQqARKx6ZDtd1kLGkTMLApCTYPSyv37BKP1AQFL20c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IaH6z6JwycjCsEbA7GCeB3n6GTdqqfJyCy2OGMe2B4HBz2efF+urw9/RQ5h3ymLuW wao2EdNZhPeKMX4qbBBU+xbYalRgrm7QAdOOTf6QHo9UAOvZvjgrDuMJBMHv80HLzz s9aidRM8R57C0UrOTk3upksg4R1LCxKytIwbLCpM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Guenter Roeck , Wim Van Sebroeck , Sasha Levin Subject: [PATCH 6.6 140/262] watchdog: ziirave_wdt: check record length in ziirave_firm_verify() Date: Tue, 12 Aug 2025 19:28:48 +0200 Message-ID: <20250812172959.055808603@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812172952.959106058@linuxfoundation.org> References: <20250812172952.959106058@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter [ Upstream commit 8b61d8ca751bc15875b50e0ff6ac3ba0cf95a529 ] The "rec->len" value comes from the firmware. We generally do trust firmware, but it's always better to double check. If the length value is too large it would lead to memory corruption when we set "data[i] = ret;" Fixes: 217209db0204 ("watchdog: ziirave_wdt: Add support to upload the firmware.") Signed-off-by: Dan Carpenter Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/3b58b453f0faa8b968c90523f52c11908b56c346.1748463049.git.dan.carpenter@linaro.org Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/ziirave_wdt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c index 5ed33df68e9a..e611d60316c6 100644 --- a/drivers/watchdog/ziirave_wdt.c +++ b/drivers/watchdog/ziirave_wdt.c @@ -302,6 +302,9 @@ static int ziirave_firm_verify(struct watchdog_device *wdd, const u16 len = be16_to_cpu(rec->len); const u32 addr = be32_to_cpu(rec->addr); + if (len > sizeof(data)) + return -EINVAL; + if (ziirave_firm_addr_readonly(addr)) continue; -- 2.39.5