From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 725643F9D2; Tue, 12 Aug 2025 18:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755022773; cv=none; b=WjdZxFvrQLXyrK67SNFfTY8iM9u3Ah/Dqpcdp8wbnM8P3SlD6/s39sUmeOmulpR5OxGck1jcSQ+aypou9gj3vspVMCwbW+y3eiFLTLjKMpLy8xI/k6cqWjjAfm+GhTfvKQonkB9kmAUb3kopLyJUXiL52z7GeCX2eHg5IwFu4IY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755022773; c=relaxed/simple; bh=a7pogepNtFPCe3hgqAtiqEbSNvUem9m6ju6u/uAB4wk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TY74x/1/16kZ9gA20DVl2DC8Ao+4vrNXYG8uc1Ak0Ps6tDf/wVia+lAFkEwFSwz/d27rGdkfpxE4cg1xlrs+sVIM3p/0rw4uOM0gnIwQFM+WmJuY7yKXMQMgqquswByYnkpkVfj448DfG2uQQrdy/AadK/P3Arcx+BBjHkfYGlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uGQ2wZeg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uGQ2wZeg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79398C4CEF6; Tue, 12 Aug 2025 18:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755022773; bh=a7pogepNtFPCe3hgqAtiqEbSNvUem9m6ju6u/uAB4wk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGQ2wZeg1rO1qkbf7RVT/zdlyMzyfiTJgMyz1jl9U0fbNzP7Bt9oZf8z+U3vANIm2 pr7uqcDmhJNhX2e6JBSfhXmGcr/B2WeTL/0c39FCgjJVuifzaIRlJqyyX2wCaFPVQS DBImJhjMmsPqGLet2ExYuM4FjswBFYNkuKPg3UCo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brian Masney , Alexandre Belloni , Sasha Levin Subject: [PATCH 6.12 247/369] rtc: pcf8563: fix incorrect maximum clock rate handling Date: Tue, 12 Aug 2025 19:29:04 +0200 Message-ID: <20250812173024.059714932@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173014.736537091@linuxfoundation.org> References: <20250812173014.736537091@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brian Masney [ Upstream commit 906726a5efeefe0ef0103ccff5312a09080c04ae ] When pcf8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: a39a6405d5f94 ("rtc: pcf8563: add CLKOUT to common clock framework") Signed-off-by: Brian Masney Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-5-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 647d52f1f5c5..23b21b908915 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -386,7 +386,7 @@ static long pcf8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate, if (clkout_rates[i] <= rate) return clkout_rates[i]; - return 0; + return clkout_rates[0]; } static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.39.5