From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5CA32FE588; Tue, 12 Aug 2025 18:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023163; cv=none; b=J0lHmF4HkGKrBdhqZl/YxRozOyz+0AX/IXRW0h87ifmka/aveTpne7+hS4CpEiEk1UxXZTSg4S7aZzo4aEyIzh8J2n4VcJaPMFLO7UoN7ALcAhxv25tfYo8S7TyuB3nmhjyBC2H3RwkC1QltyjF3fwavTeNFFMW5dsii3YC/hNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023163; c=relaxed/simple; bh=KqKx5OuOC8iv/kI251xfbVs5M3hOBqxTlvVtfs5L4+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FEQJGOKdZQjNJKJ+y8Q+QGCX/dkv/lPnQqGBv8hphvZGh2EDTcuXTZPL/kvISGkS+guWUVQFiQvPBbm1Gv5BHuZCX8Xenx8jw/hOBrez+tCORX7ugXOH9gvfefo7noiudlzke9vYK9PzDIRF1u5U4FDWrU88a0k70Uo3LKw2M88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n6ToO7G/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n6ToO7G/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59A44C4CEF0; Tue, 12 Aug 2025 18:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755023163; bh=KqKx5OuOC8iv/kI251xfbVs5M3hOBqxTlvVtfs5L4+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6ToO7G/Us1jAzx9weuVVvd43pycLP5MPb1xMXXvfoKV0fzUYA9p96kc3kqRK370k sKyjpKpS5man1Mf5NmNtsgJbczw6jI1CVlJCknFbAq61Occ2FeW9Br1s2Sfn2j+bbm ORj9CgTl/9fgCBzXKTSz/vVqipEK5afEHIps+FSU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Tao Xue Subject: [PATCH 6.12 369/369] usb: gadget : fix use-after-free in composite_dev_cleanup() Date: Tue, 12 Aug 2025 19:31:06 +0200 Message-ID: <20250812173030.561938606@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173014.736537091@linuxfoundation.org> References: <20250812173014.736537091@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tao Xue commit 151c0aa896c47a4459e07fee7d4843f44c1bb18e upstream. 1. In func configfs_composite_bind() -> composite_os_desc_req_prepare(): if kmalloc fails, the pointer cdev->os_desc_req will be freed but not set to NULL. Then it will return a failure to the upper-level function. 2. in func configfs_composite_bind() -> composite_dev_cleanup(): it will checks whether cdev->os_desc_req is NULL. If it is not NULL, it will attempt to use it.This will lead to a use-after-free issue. BUG: KASAN: use-after-free in composite_dev_cleanup+0xf4/0x2c0 Read of size 8 at addr 0000004827837a00 by task init/1 CPU: 10 PID: 1 Comm: init Tainted: G O 5.10.97-oh #1 kasan_report+0x188/0x1cc __asan_load8+0xb4/0xbc composite_dev_cleanup+0xf4/0x2c0 configfs_composite_bind+0x210/0x7ac udc_bind_to_driver+0xb4/0x1ec usb_gadget_probe_driver+0xec/0x21c gadget_dev_desc_UDC_store+0x264/0x27c Fixes: 37a3a533429e ("usb: gadget: OS Feature Descriptors support") Cc: stable Signed-off-by: Tao Xue Link: https://lore.kernel.org/r/20250721093908.14967-1-xuetao09@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/composite.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -2489,6 +2489,11 @@ int composite_os_desc_req_prepare(struct if (!cdev->os_desc_req->buf) { ret = -ENOMEM; usb_ep_free_request(ep0, cdev->os_desc_req); + /* + * Set os_desc_req to NULL so that composite_dev_cleanup() + * will not try to free it again. + */ + cdev->os_desc_req = NULL; goto end; } cdev->os_desc_req->context = cdev;