From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F5722F4A0A; Tue, 12 Aug 2025 18:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023590; cv=none; b=LlAp2HpexJp0BDZxGDw5fCkvNrmWk4akZ+7PGsTDyYfbJOQBaqu1e6hED+z3WhYyxcD/BmeAE/my35i15SBvx8DlTs3WZXjNTZ7Ds3wA3E1CKXTUTCl+ZsUMbWk3kU9muPHuIxZsiiJCHmKetkJniWZpCrPKhfjm3FmDDMafQFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023590; c=relaxed/simple; bh=68Qys1e2DPB/2G+KPdFdIDaH+atrXh5cr5A0FEAQRDc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B/5ULL1rlxM2o1hnCK9/V4sDgqBIaLPOSx2z1frKUFW8+JiAfX0V6NxSm54Ftyxg5nxWWG+bLuYRz7RcewYMgZssu7rrhdKJDRMs8oh0UNhNS+7ESO021B0pTDD4xuzLtFa3z8KzKaXLPjoNgv6aXd6j7EKhC/ntvzQ1k3UnCZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UBnAyC8G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UBnAyC8G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0F84C4CEF0; Tue, 12 Aug 2025 18:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755023590; bh=68Qys1e2DPB/2G+KPdFdIDaH+atrXh5cr5A0FEAQRDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UBnAyC8Gu61kj9JLiqHfO+0yfiXs7q0dDymZK7+cAJdPSyeGIo9+ahPmbxsQI5kIR wCNTckmVKkAAJAeAMmY/12+j0o25wX2d5BHrfpzmyXwA4e/EwaGgKEiEB7ONykpY2m 0OB3ASJ8WEGMN3eTbdfgLEi8ZpIKi+phpIS6XoXs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rodrigo Vivi , "Michael J. Ruhl" , "David E. Box" , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 6.16 124/627] drm/xe: Correct BMG VSEC header sizing Date: Tue, 12 Aug 2025 19:26:59 +0200 Message-ID: <20250812173424.036665694@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173419.303046420@linuxfoundation.org> References: <20250812173419.303046420@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael J. Ruhl [ Upstream commit 5b27388171a18cf6842c700520086ec50194e858 ] The intel_vsec_header information for the crashlog feature is incorrect. Update the VSEC header with correct sizing and count. Since the crashlog entries are "merged" (num_entries = 2), the separate capabilities entries must be merged as well. Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices") Acked-by: Rodrigo Vivi Signed-off-by: Michael J. Ruhl Reviewed-by: David E. Box Link: https://lore.kernel.org/r/20250713172943.7335-4-michael.j.ruhl@intel.com Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/gpu/drm/xe/xe_vsec.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index 1bf7e709e110..56930ad42962 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -33,30 +33,19 @@ static struct intel_vsec_header bmg_telemetry = { .offset = BMG_DISCOVERY_OFFSET, }; -static struct intel_vsec_header bmg_punit_crashlog = { +static struct intel_vsec_header bmg_crashlog = { .rev = 1, .length = 0x10, .id = VSEC_ID_CRASHLOG, - .num_entries = 1, - .entry_size = 4, + .num_entries = 2, + .entry_size = 6, .tbir = 0, .offset = BMG_DISCOVERY_OFFSET + 0x60, }; -static struct intel_vsec_header bmg_oobmsm_crashlog = { - .rev = 1, - .length = 0x10, - .id = VSEC_ID_CRASHLOG, - .num_entries = 1, - .entry_size = 4, - .tbir = 0, - .offset = BMG_DISCOVERY_OFFSET + 0x78, -}; - static struct intel_vsec_header *bmg_capabilities[] = { &bmg_telemetry, - &bmg_punit_crashlog, - &bmg_oobmsm_crashlog, + &bmg_crashlog, NULL }; -- 2.39.5