From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0F4E2E285E; Tue, 12 Aug 2025 18:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023642; cv=none; b=Y0x5NdjlVkXXDagHpjusZYfKOMkwkq88/oTPNnPPMGy5j+WhsZDHZPYuJVQPsfr5Vms6glar/9mM5gsz1u3ENSDmaUDgV/j7NJaCj8ox7zWiaJ2sOnONz91JL96n7fTJSEAnN3Ks9ATSSogb3TxeIoj1vDFIMUSTGsurAHlmd80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755023642; c=relaxed/simple; bh=CKvLHWFNb33M1tH7BiCOJyHB0yrLfjxxh+0JrOz9Zu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tYWgIKItKWtoQ/t2/JbJEItcO49OWS4QSSe06hp5EtI+YQfRtZUbNFqMm/WTAAKmdUKv9JgTGjk6A6iuMzktMGLpgzQuCl0RJzS26T8sevO6ojoJXyS1aO79S1kAXj146FMp3fxLPxEzhqbwcVM+lVCQ1oTQ+rBjLt9bcVy2WyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RS9O9KHX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RS9O9KHX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F4FEC4CEF0; Tue, 12 Aug 2025 18:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755023642; bh=CKvLHWFNb33M1tH7BiCOJyHB0yrLfjxxh+0JrOz9Zu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RS9O9KHXYUIL+tpsZHZtPD9FY/FwivHHGwnmeRvkRcFIObdPMAW3YmqC9/oqW3lcQ Jz9yVDyj220UTkjfqfMza2ZUEWUUGXyiypU2ytwcSl8Oy9KTXK3eVihdjEgP+9EF85 u+43N7HSVFde3VvUI4cj+wQ2llx4R0af/0fpJlNw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Yan , Heiko Stuebner , Sasha Levin Subject: [PATCH 6.16 132/627] drm/rockchip: cleanup fb when drm_gem_fb_afbc_init failed Date: Tue, 12 Aug 2025 19:27:07 +0200 Message-ID: <20250812173424.335924655@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173419.303046420@linuxfoundation.org> References: <20250812173419.303046420@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Yan [ Upstream commit 099593a28138b48feea5be8ce700e5bc4565e31d ] In the function drm_gem_fb_init_with_funcs, the framebuffer (fb) and its corresponding object ID have already been registered. So we need to cleanup the drm framebuffer if the subsequent execution of drm_gem_fb_afbc_init fails. Directly call drm_framebuffer_put to ensure that all fb related resources are cleanup. Fixes: 7707f7227f09 ("drm/rockchip: Add support for afbc") Signed-off-by: Andy Yan Signed-off-by: Heiko Stuebner Link: https://lore.kernel.org/r/20250509031607.2542187-1-andyshrk@163.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index dcc1f07632c3..5829ee061c61 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c @@ -52,16 +52,9 @@ rockchip_fb_create(struct drm_device *dev, struct drm_file *file, } if (drm_is_afbc(mode_cmd->modifier[0])) { - int ret, i; - ret = drm_gem_fb_afbc_init(dev, mode_cmd, afbc_fb); if (ret) { - struct drm_gem_object **obj = afbc_fb->base.obj; - - for (i = 0; i < info->num_planes; ++i) - drm_gem_object_put(obj[i]); - - kfree(afbc_fb); + drm_framebuffer_put(&afbc_fb->base); return ERR_PTR(ret); } } -- 2.39.5