From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 259402FF169; Tue, 12 Aug 2025 18:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755024639; cv=none; b=sUGBpAwsWQ+hSl9UcHGGg/qm2gvn/RxHscEpve4lS7jNamtdedXlT4K2J0b7X1tIBob3xQOyJjwwMna1JhvA+zr6d5BiqRWKj1Qg52KUy8h8dwWN70MAKCPfP+pBk7Ydf6Ez1ev6NOOYVEfMl4zRmLJAHorchZXNKKRSPzQQ9RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755024639; c=relaxed/simple; bh=rPuIT9brpWsP1cHZizOuTbIQV9LScM3yy56j5seoMB0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AqYK565HhG0qnxFnNHuMKNxgG1a1ADWVQ8k3/9grzDzRimA7TdHCt/akMFQPM6unVJh0ccxkHuDReAdH7xAILycLIn0edyMQHgI+8dA/PhzOWE0vJ7F2RLyqen2rsLCy7LLrIP+BW1COPWqs1ll5mrGmHp3PkkwmWkj6CviJ+kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lfVmQ3IB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lfVmQ3IB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88D4DC4CEF7; Tue, 12 Aug 2025 18:50:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755024639; bh=rPuIT9brpWsP1cHZizOuTbIQV9LScM3yy56j5seoMB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lfVmQ3IBndLu1FgD88H4KQx+iedeGHc+jaqk3oMJj3q4YUFkmRBXbgtI7e0KEhp6f 7aXqdK22nGfuJOL6YFZ7SdFGSZNwD1o1auBSF2QJjFnoSR7JxOjruc8ma71QXhNCwf NaEE9RSQDluIUchtBHTkV9Ci5pfipeLvNqByMu2A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zheng Yu , Dave Kleikamp , Sasha Levin Subject: [PATCH 6.16 433/627] jfs: fix metapage reference count leak in dbAllocCtl Date: Tue, 12 Aug 2025 19:32:08 +0200 Message-ID: <20250812173435.752798012@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173419.303046420@linuxfoundation.org> References: <20250812173419.303046420@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zheng Yu [ Upstream commit 856db37592021e9155384094e331e2d4589f28b1 ] In dbAllocCtl(), read_metapage() increases the reference count of the metapage. However, when dp->tree.budmin < 0, the function returns -EIO without calling release_metapage() to decrease the reference count, leading to a memory leak. Add release_metapage(mp) before the error return to properly manage the metapage reference count and prevent the leak. Fixes: a5f5e4698f8abbb25fe4959814093fb5bfa1aa9d ("jfs: fix shift-out-of-bounds in dbSplit") Signed-off-by: Zheng Yu Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 35e063c9f3a4..5a877261c3fe 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -1809,8 +1809,10 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results) return -EIO; dp = (struct dmap *) mp->data; - if (dp->tree.budmin < 0) + if (dp->tree.budmin < 0) { + release_metapage(mp); return -EIO; + } /* try to allocate the blocks. */ -- 2.39.5