From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDE97284685; Tue, 12 Aug 2025 18:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755024813; cv=none; b=SiKWlzXqrbXgvdFqfD6GdIP4TEMNm8NpsYk3Hq6hk3cp7SI3NRFhNTCE3PnwLzR0kmiz+6adS1bVGE2sL1QEIapQRmNBLzYULppLvUSNEsxCSQiftizSRdKgxtFDgwSIhUdv3UcjtYYPfylF6ndaM79rkjvP0TXRjnGQuYt7wHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755024813; c=relaxed/simple; bh=QKOV50Aq/AgeF3pzWfOTzmdjLn1LKfkcxKPuG6Zvydw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZWZULZqIWQQ/tHVT3ATz/RzWwnG28qd7TWak5sQRlN6HiqNQQQfdq4nVu8VsSdp6rg+mA5uXMFxh/VergKVN8SmfQinyAz7cVUDgJ/652RpmL2Az4JpLxVEW0xGmND7bkoOcw/JGqzE8Vs7cE+ziBxFyFLoTWj7Tx3KHGMuW+2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=by1HkOF8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="by1HkOF8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E309CC4CEF0; Tue, 12 Aug 2025 18:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755024812; bh=QKOV50Aq/AgeF3pzWfOTzmdjLn1LKfkcxKPuG6Zvydw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=by1HkOF8mXdajz2Vgno1VMUUyGFkL7e3pnWhTkGujl5vwy0VvSo/FMQs2sjji7Zp5 USj/LRELHFWEQ98C/LsCm+5+4TxSGxfCs30Qs0gSfqVJG/Usjl68wFwgmFtFsVod8b ydx9hxDx+OXqMp+xCP6dSionU2VT8PyU+6lW0N+k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.16 483/627] f2fs: fix to avoid out-of-boundary access in devs.path Date: Tue, 12 Aug 2025 19:32:58 +0200 Message-ID: <20250812173443.600417268@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250812173419.303046420@linuxfoundation.org> References: <20250812173419.303046420@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chao Yu [ Upstream commit 5661998536af52848cc4d52a377e90368196edea ] - touch /mnt/f2fs/012345678901234567890123456789012345678901234567890123 - truncate -s $((1024*1024*1024)) \ /mnt/f2fs/012345678901234567890123456789012345678901234567890123 - touch /mnt/f2fs/file - truncate -s $((1024*1024*1024)) /mnt/f2fs/file - mkfs.f2fs /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \ -c /mnt/f2fs/file - mount /mnt/f2fs/012345678901234567890123456789012345678901234567890123 \ /mnt/f2fs/loop [16937.192225] F2FS-fs (loop0): Mount Device [ 0]: /mnt/f2fs/012345678901234567890123456789012345678901234567890123\xff\x01, 511, 0 - 3ffff [16937.192268] F2FS-fs (loop0): Failed to find devices If device path length equals to MAX_PATH_LEN, sbi->devs.path[] may not end up w/ null character due to path array is fully filled, So accidently, fields locate after path[] may be treated as part of device path, result in parsing wrong device path. struct f2fs_dev_info { ... char path[MAX_PATH_LEN]; ... }; Let's add one byte space for sbi->devs.path[] to store null character of device path string. Fixes: 3c62be17d4f5 ("f2fs: support multiple devices") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index da2137e9d03f..e084b96f1109 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1286,7 +1286,7 @@ struct f2fs_bio_info { struct f2fs_dev_info { struct file *bdev_file; struct block_device *bdev; - char path[MAX_PATH_LEN]; + char path[MAX_PATH_LEN + 1]; unsigned int total_segments; block_t start_blk; block_t end_blk; -- 2.39.5