From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42F5421ABAA; Mon, 18 Aug 2025 12:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521399; cv=none; b=K8jXfU5jFEdqN8MbPtfp7OFaZNTaxVRXCfDZphICdwhiChMrrpVFHadWFm5Y+y9Zbly5dCioFXWXgzLAsCVnVIcUeoBVmZAXvSa1gCB37uuFZZYEiALf9xC/mxFik2XkTthUwMb1Sz3JJ9qwkYbK48+BeqJ+MAU9k6T6FlJCegQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521399; c=relaxed/simple; bh=2U0qhL68EeJxioRzFglX7aabtB2pvir/Oji2J0Vn1X0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tf9boqezHIhUDE8LvkYH3gMkCANqQojrcdDHrQN+2LOm0piSGaGN6LBH/EnIAd7gfNHXgF0XnfEjr18ddK32uYTBhLISToEnQgRnaYNvTtIda2vwp2oWPigYAww/EhbeZMs0ziiXR65spxLiEy1yMonVjXSnEkNQ9aA5KGjkp8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wceiSKk6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wceiSKk6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52E5DC4CEEB; Mon, 18 Aug 2025 12:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755521398; bh=2U0qhL68EeJxioRzFglX7aabtB2pvir/Oji2J0Vn1X0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wceiSKk6fI4GtrRekrj9aJT8RQaaux+AM/5wAaMW5pJ/MMigSL/pRTzDKV3EGWDpd PksG/gMf0xGk2ISQVD9qfFJvFetv04+K/P2BC+ddsZ+03nfgQ328RxfTmdeEd64V5C WCIG8ANmzAQKdzEPu2/IRSGfW9R5R0qhksD0ePO4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai , Youngjun Lee Subject: [PATCH 6.12 002/444] ALSA: usb-audio: Validate UAC3 power domain descriptors, too Date: Mon, 18 Aug 2025 14:40:28 +0200 Message-ID: <20250818124448.976701428@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit d832ccbc301fbd9e5a1d691bdcf461cdb514595f upstream. UAC3 power domain descriptors need to be verified with its variable bLength for avoiding the unexpected OOB accesses by malicious firmware, too. Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") Reported-and-tested-by: Youngjun Lee Cc: Link: https://patch.msgid.link/20250814081245.8902-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/validate.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/sound/usb/validate.c +++ b/sound/usb/validate.c @@ -221,6 +221,17 @@ static bool validate_uac3_feature_unit(c return d->bLength >= sizeof(*d) + 4 + 2; } +static bool validate_uac3_power_domain_unit(const void *p, + const struct usb_desc_validator *v) +{ + const struct uac3_power_domain_descriptor *d = p; + + if (d->bLength < sizeof(*d)) + return false; + /* baEntities[] + wPDomainDescrStr */ + return d->bLength >= sizeof(*d) + d->bNrEntities + 2; +} + static bool validate_midi_out_jack(const void *p, const struct usb_desc_validator *v) { @@ -285,6 +296,7 @@ static const struct usb_desc_validator a struct uac3_clock_multiplier_descriptor), /* UAC_VERSION_3, UAC3_SAMPLE_RATE_CONVERTER: not implemented yet */ /* UAC_VERSION_3, UAC3_CONNECTORS: not implemented yet */ + FUNC(UAC_VERSION_3, UAC3_POWER_DOMAIN, validate_uac3_power_domain_unit), { } /* terminator */ };