From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112D3322757; Mon, 18 Aug 2025 12:51:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521472; cv=none; b=lhr5dZ8A6FWXMtSNwqpYL3eIiMAc2jcoa0eo3oSJg3QDBdvFXTzr/Ldw+vOgODGiLJlwpAdyc6Cce4Nwfg9PDJzQQKMYDeo05UFeUC6KzYVxzfryxKdhWyPWR9773KOWedQBiUOK0IscvnV2CvmZKreVqGpN2bmIJiqlOBxjrhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521472; c=relaxed/simple; bh=7vkpdhlPTmPOfOIKQu5rbyIfVAF1tL0mstzzFEuP1w0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X3SiWvnoaDwHb5jKF/Yoqvp1UXe/QDVfhEUjWL0Q46p5TNeOGzCWGq6BXTR13BnUOVC2A0XHlsZlTvobVdpQDsQUI1vhUPAGjFUqOKMETFE131sqbtB3keucJlxNuAS0rM9tpOn+F33JM9oCmcY7RPg/XiM1A5XMZAEm0ywXK2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=r6iMNDBE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="r6iMNDBE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A1B9C4CEF1; Mon, 18 Aug 2025 12:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755521471; bh=7vkpdhlPTmPOfOIKQu5rbyIfVAF1tL0mstzzFEuP1w0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r6iMNDBE0v+mnEQqmEaTLuWrRhFVLltIWQEfm3I4NLeocjNbUEsCRiGRNCwijIANJ EHbDqyjue1HerjzuX/tXiaOmDIhh8ICZSdbEoJUUMUNgTajc4I2+gtNsBsH/On+xPl bFbmT3hwVscwDbr801RglXMq4oZUV/fbTSFzogE0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiaxun Yang , Yao Zi , Huacai Chen Subject: [PATCH 6.12 030/444] LoongArch: Avoid in-place string operation on FDT content Date: Mon, 18 Aug 2025 14:40:56 +0200 Message-ID: <20250818124450.057851619@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yao Zi commit 70a2365e18affc5ebdaab1ca6a0b3c4f3aac2ee8 upstream. In init_cpu_fullname(), a constant pointer to "model" property is retrieved. It's later modified by the strsep() function, which is illegal and corrupts kernel's FDT copy. This is shown by dmesg, OF: fdt: not creating '/sys/firmware/fdt': CRC check failed Create a mutable copy of the model property and do in-place operations on the mutable copy instead. loongson_sysconf.cpuname lives across the kernel lifetime, thus manually releasing isn't necessary. Also move the of_node_put() call for the root node after the usage of its property, since of_node_put() decreases the reference counter thus usage after the call is unsafe. Cc: stable@vger.kernel.org Fixes: 44a01f1f726a ("LoongArch: Parsing CPU-related information from DTS") Reviewed-by: Jiaxun Yang Signed-off-by: Yao Zi Signed-off-by: Huacai Chen Signed-off-by: Greg Kroah-Hartman --- arch/loongarch/kernel/env.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/arch/loongarch/kernel/env.c +++ b/arch/loongarch/kernel/env.c @@ -39,16 +39,19 @@ void __init init_environ(void) static int __init init_cpu_fullname(void) { - struct device_node *root; int cpu, ret; - char *model; + char *cpuname; + const char *model; + struct device_node *root; /* Parsing cpuname from DTS model property */ root = of_find_node_by_path("/"); - ret = of_property_read_string(root, "model", (const char **)&model); + ret = of_property_read_string(root, "model", &model); + if (ret == 0) { + cpuname = kstrdup(model, GFP_KERNEL); + loongson_sysconf.cpuname = strsep(&cpuname, " "); + } of_node_put(root); - if (ret == 0) - loongson_sysconf.cpuname = strsep(&model, " "); if (loongson_sysconf.cpuname && !strncmp(loongson_sysconf.cpuname, "Loongson", 8)) { for (cpu = 0; cpu < NR_CPUS; cpu++)