From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D8B20126A; Mon, 18 Aug 2025 12:55:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521720; cv=none; b=PeEVUPyQdf2CtsK/qvitv1I0S6pfCnati80Zqp1gIEPhdXXboomDkrQQbmqjwykkpse6wpZI7rWH9ZKHUQOOQEs5AqzBZZsJmdnXomuqmVYJvwrFhtSKuZAnT5LSE8cZ/afiOdZS+pb5w+O2nsu4jWV6V32LO1gmT5SIvu5QqgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521720; c=relaxed/simple; bh=X5kvw1r63CXzTaps6UjCSw7PE/M26ByaFKHSPj9EtLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JQpB7qd7cbseRmn0LM3Caa0KVU1x2hdq9J8XF8H1iarEw7VWI8qiMFdxT4H7hlU+GJMwosipbztDeXEPLwYpGVaMOnCF447ArNZL2pF1Qv9SY5YFXrbx7hQtRdcRBwa1aA5bBtXVA0qjumPDcWzLFn4tmZUi5/l6I6B9a5mBWD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ay147iir; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ay147iir" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88954C4CEEB; Mon, 18 Aug 2025 12:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755521719; bh=X5kvw1r63CXzTaps6UjCSw7PE/M26ByaFKHSPj9EtLs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ay147iirP9LxLRJ9GYbsna3knCI7u+5SDsUeD8+Qrf0tf85RwO/pEiAfdC5G6o4x5 qOREdNXXWfvDCKW4h3mfiS/gXFUsQvG+EzNNmtjnU6GqklC8r8kJH2/G7ar7fC1FYy G6uYOQCY8wyHONg4XXq13M2k19sV4jJBwwkEUkMM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Mathias Nyman , Sasha Levin Subject: [PATCH 6.12 102/444] usb: xhci: Avoid showing errors during surprise removal Date: Mon, 18 Aug 2025 14:42:08 +0200 Message-ID: <20250818124452.768364730@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello [ Upstream commit 4b9c60e440525b729ac5f071e00bcee12e0a7e84 ] When a USB4 dock is unplugged from a system it won't respond to ring events. The PCI core handles the surprise removal event and notifies all PCI drivers. The XHCI PCI driver sets a flag that the device is being removed as well. When that flag is set don't show messages in the cleanup path for marking the controller dead. Signed-off-by: Mario Limonciello Signed-off-by: Mathias Nyman Acked-by: Mathias Nyman Link: https://lore.kernel.org/r/20250717073107.488599-2-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/xhci-ring.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 19978f02bb9e..f6ecb3b9fb14 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -1313,12 +1313,15 @@ static void xhci_kill_endpoint_urbs(struct xhci_hcd *xhci, */ void xhci_hc_died(struct xhci_hcd *xhci) { + bool notify; int i, j; if (xhci->xhc_state & XHCI_STATE_DYING) return; - xhci_err(xhci, "xHCI host controller not responding, assume dead\n"); + notify = !(xhci->xhc_state & XHCI_STATE_REMOVING); + if (notify) + xhci_err(xhci, "xHCI host controller not responding, assume dead\n"); xhci->xhc_state |= XHCI_STATE_DYING; xhci_cleanup_command_queue(xhci); @@ -1332,7 +1335,7 @@ void xhci_hc_died(struct xhci_hcd *xhci) } /* inform usb core hc died if PCI remove isn't already handling it */ - if (!(xhci->xhc_state & XHCI_STATE_REMOVING)) + if (notify) usb_hc_died(xhci_to_hcd(xhci)); } -- 2.39.5