From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 533E81EFFB4; Mon, 18 Aug 2025 13:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522073; cv=none; b=fgYW/DKM1DEzykRsG3gRz8XEIpBtcM0dUxS5YClbFDrvTezrXtxr4/+B7J6V781uCr6e9NF2+mFbi2TThXVQ9m/8zzVmkYvWiQ30D30iz4Z50aGSXkKEuDtQFEAmsWE5TnD5E5i4kYoqqmf30EROcgGY6xKIp3k0BvQ/4yFJt90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522073; c=relaxed/simple; bh=z6GO0AtIFFfDRwNT3nBzg4WD/vs32oJ+zbupkU35HFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D4/ZTofP/JzLJDymIeD0/eHR8AFh5820ZtniR7fwZlWC0IE2+FUVbXlWaLFrrsiJphibOllue322h2VabxJmiZEqb7w+lhvJ6FrDRKbKPGSYIIt0S64SILcsV6RMrYW/nE5ny16VtwbGbFk+cHUe5podyO6vl9JmGh7nnY5aDcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FgOgd4Xr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FgOgd4Xr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A86A7C113D0; Mon, 18 Aug 2025 13:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755522073; bh=z6GO0AtIFFfDRwNT3nBzg4WD/vs32oJ+zbupkU35HFw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FgOgd4XrdCxqoVqsTSb8AWIk0SCs8X8y+q3iOAt3fVI9e7LK9lkXyCyT1J/egSboi jLmDSrLuiCwv2rdnvgGaFISZqH06JtF8iIn5KBUdIHjO9c2llloxANesscjmb8AJ6m CwAYkn90lAYX+bF2zkbPEtRAeGFTyfNlnG7QaDVc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Fourier , Christophe Leroy , Madhavan Srinivasan , Sasha Levin Subject: [PATCH 6.12 206/444] (powerpc/512) Fix possible `dma_unmap_single()` on uninitialized pointer Date: Mon, 18 Aug 2025 14:43:52 +0200 Message-ID: <20250818124456.583511384@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Fourier [ Upstream commit 760b9b4f6de9a33ca56a05f950cabe82138d25bd ] If the device configuration fails (if `dma_dev->device_config()`), `sg_dma_address(&sg)` is not initialized and the jump to `err_dma_prep` leads to calling `dma_unmap_single()` on `sg_dma_address(&sg)`. Signed-off-by: Thomas Fourier Reviewed-by: Christophe Leroy Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/20250610142918.169540-2-fourier.thomas@gmail.com Signed-off-by: Sasha Levin --- arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c index 9668b052cd4b..f251e0f68262 100644 --- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c +++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c @@ -240,10 +240,8 @@ static int mpc512x_lpbfifo_kick(void) dma_conf.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; /* Make DMA channel work with LPB FIFO data register */ - if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) { - ret = -EINVAL; - goto err_dma_prep; - } + if (dma_dev->device_config(lpbfifo.chan, &dma_conf)) + return -EINVAL; sg_init_table(&sg, 1); -- 2.39.5