From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C2C31E0FB; Mon, 18 Aug 2025 13:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522244; cv=none; b=VbCrCmxgBivP7ywzRHrDRo9ebnGLt9lTFwukhbHFhG3++qoMUvla2YEPewbW8u39JTKf1WGigbe5bYy+TV67+DMe3/WwUmcuyZjBfQuuVwtGi4V0MgFg46KlJf/sLSL0wuE2cPnW3zsZMbrC9huX7VGv1sxlh7k+pFIBwj+cqFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522244; c=relaxed/simple; bh=lPlDjVAplw4bGr0939b0ZF4NmKpGFo+yFDoTFeA8JcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eNEf86wTIwkj9YTPSLpNq9KsVY1LavruU63ROBqY0R7ajtICHMQTyGB9DycDT5sVOI3pWT0iYnJ5vrllAZ2vX+qSbtk6x+lq9GHgdEMRLM1GG6chS7+EQmh2aHSz3Rl1HrCJKQVhNocz87bTurzPBqvGpKf1hPF4qNDvo4XMv1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=J52UzB8u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="J52UzB8u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5819DC4CEEB; Mon, 18 Aug 2025 13:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755522243; bh=lPlDjVAplw4bGr0939b0ZF4NmKpGFo+yFDoTFeA8JcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J52UzB8um7MKIndNoqsPh3LmGqvjzo5dluTCAE+3hg594zkmqYks6shmnj5JesPYs F57P7LS+Li1uYbm4Tn7hfDlBfmsw0kXcU3nrWa+V/X2ODMovwMKnh8fm0qoSZ1Bvbi KSbTUTqdFmZH1/X/3wbl4Yceg7fKJEjwFFSPwJ/0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nevenko Stupar , Ilya Bakoulin , Ray Wu , Daniel Wheeler , Alex Deucher , Sasha Levin Subject: [PATCH 6.12 225/444] drm/amd/display: Separate set_gsl from set_gsl_source_select Date: Mon, 18 Aug 2025 14:44:11 +0200 Message-ID: <20250818124457.281587699@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ilya Bakoulin [ Upstream commit 660a467a5e7366cd6642de61f1aaeaf0d253ee68 ] [Why/How] Separate the checks for set_gsl and set_gsl_source_select, since source_select may not be implemented/necessary. Reviewed-by: Nevenko Stupar Signed-off-by: Ilya Bakoulin Signed-off-by: Ray Wu Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c index 9c5cdb3b80b5..d9de8e17ccf4 100644 --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c @@ -273,14 +273,13 @@ void dcn20_setup_gsl_group_as_lock( } /* at this point we want to program whether it's to enable or disable */ - if (pipe_ctx->stream_res.tg->funcs->set_gsl != NULL && - pipe_ctx->stream_res.tg->funcs->set_gsl_source_select != NULL) { + if (pipe_ctx->stream_res.tg->funcs->set_gsl != NULL) { pipe_ctx->stream_res.tg->funcs->set_gsl( pipe_ctx->stream_res.tg, &gsl); - - pipe_ctx->stream_res.tg->funcs->set_gsl_source_select( - pipe_ctx->stream_res.tg, group_idx, enable ? 4 : 0); + if (pipe_ctx->stream_res.tg->funcs->set_gsl_source_select != NULL) + pipe_ctx->stream_res.tg->funcs->set_gsl_source_select( + pipe_ctx->stream_res.tg, group_idx, enable ? 4 : 0); } else BREAK_TO_DEBUGGER(); } -- 2.39.5