From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B92CE28C849; Mon, 18 Aug 2025 13:06:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522404; cv=none; b=OjjYqzUdRneoA1MrsWCxSf4xp3JH+3eESOREEZUucXJ+tgD2q1xJ+CeQMuTCExBH5skaFwm7y/g3PjWVeRelOibTVur0cWs7/AH8I/f07nmfUDzATZ2HDAAkOD8jRO9bkYDuvnmGdSdQFGu0nn9MmGwCndj7eJu9eOA6u9HMTc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522404; c=relaxed/simple; bh=AqnVlF6baDgnK7xfAJ+734kbPOaJl3rvBUWbNSp2sBs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l5Wh87Jh2TQjVD9Dccv+94KPvG//x9z+ci+toj0zhoj9WmH/uFYdn6Jui3Avvvj2i8fhLeYr+FzjzSTEWr+I/l51TWhKKDzxGd7GwtrfEtM1OEAyS8u9GGm1QYNiOQ5XHQS9V59sx6WMJcI9BfOqHmXNd3LObiN6SuYqUCxrMLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UkDadlu6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UkDadlu6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E46EC4CEEB; Mon, 18 Aug 2025 13:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755522404; bh=AqnVlF6baDgnK7xfAJ+734kbPOaJl3rvBUWbNSp2sBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UkDadlu6BL5qyvziAIJ9xyWVMiwRq3oRBM9tPvPkrReZypo7sDw7X11b60Np2N1Tq 9okl6hioMtWLKicbSM0CWEgTSe66xYiDPEFH8KoKRJ3vAIzhRmCYV1U2cQ7mgOqKnC NkswojOpNDOoqmPAaL9H/prLV5zyHZ7887+xMRgY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Justin Tee , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.12 307/444] scsi: lpfc: Ensure HBA_SETUP flag is used only for SLI4 in dev_loss_tmo_callbk Date: Mon, 18 Aug 2025 14:45:33 +0200 Message-ID: <20250818124500.464284630@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Justin Tee [ Upstream commit 1cced5779e7a3ff7ec025fc47c76a7bd3bb38877 ] For SLI3, the HBA_SETUP flag is never set so the lpfc_dev_loss_tmo_callbk always early returns. Add a phba->sli_rev check for SLI4 mode so that the SLI3 path can flow through the original dev_loss_tmo worker thread design to lpfc_dev_loss_tmo_handler instead of early return. Signed-off-by: Justin Tee Link: https://lore.kernel.org/r/20250618192138.124116-9-justintee8345@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index b5dd17eecf82..3ba515c1fe3a 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -177,7 +177,8 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) /* Don't schedule a worker thread event if the vport is going down. */ if (test_bit(FC_UNLOADING, &vport->load_flag) || - !test_bit(HBA_SETUP, &phba->hba_flag)) { + (phba->sli_rev == LPFC_SLI_REV4 && + !test_bit(HBA_SETUP, &phba->hba_flag))) { spin_lock_irqsave(&ndlp->lock, iflags); ndlp->rport = NULL; -- 2.39.5