From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEEB63218CA; Mon, 18 Aug 2025 13:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522533; cv=none; b=KsTNmyMFrY/Cc2tCQszh4bjw5DTVD2otIjol9WmI2lD5bVtyQl9js7ZQbPoHej83cLfCAd4fKFVRFLRFWa0yBH39c36OF9RwdrbunAyioM5cnjfGzBMRwlEtSe9dRWuFSrQrtN+fYmB/3E+mZ5SCqBsZo0ZVbhI5dS4mKvuUHO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755522533; c=relaxed/simple; bh=KyH/XZH812HYI74nJpca9gc0ng2BO301rD5tWnb1p08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dG36QJcMYFv/81EIqWwwqFiRzPRLX+PxSxljAKHrfLSFiTDE1z4bj6BhMUKFgyyVcSvEFA9I/4gM6OZyuo0PTdyv9DNVIsE0VKg548ZGzekVG5Cujx86Y2ncYLscxSjluHsHFP4zlvIhLniTC3s3SGvg8Z/Oae5TcuutB+/KJvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UL7YUpXY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UL7YUpXY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DAA5C4CEEB; Mon, 18 Aug 2025 13:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755522533; bh=KyH/XZH812HYI74nJpca9gc0ng2BO301rD5tWnb1p08=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UL7YUpXYwGX2yTwVvRkGZRU14A3xs2DUN9pyHCZr0TakNFTInxQQc4upcXKfFV3ll A22KwEueZpB/0LkCmPV8jAleQ/8q4haQaIzlGL0V25md/eBYSGCarPb4xYFnTC03cp xOAOdZmo6nD4De6rfCWF61ZwcRwz1NU6f+Q0owew= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shankari Anand , Masahiro Yamada , Randy Dunlap , Nicolas Schier , Sasha Levin Subject: [PATCH 6.12 344/444] kconfig: nconf: Ensure null termination where strncpy is used Date: Mon, 18 Aug 2025 14:46:10 +0200 Message-ID: <20250818124501.824856728@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124448.879659024@linuxfoundation.org> References: <20250818124448.879659024@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shankari Anand [ Upstream commit f468992936894c9ce3b1659cf38c230d33b77a16 ] strncpy() does not guarantee null-termination if the source string is longer than the destination buffer. Ensure the buffer is explicitly null-terminated to prevent potential string overflows or undefined behavior. Signed-off-by: Shankari Anand Signed-off-by: Masahiro Yamada Acked-by: Randy Dunlap Tested-by: Randy Dunlap Tested-by: Nicolas Schier Acked-by: Nicolas Schier Signed-off-by: Sasha Levin --- scripts/kconfig/nconf.c | 2 ++ scripts/kconfig/nconf.gui.c | 1 + 2 files changed, 3 insertions(+) diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c index 063b4f7ccbdb..5f484422278e 100644 --- a/scripts/kconfig/nconf.c +++ b/scripts/kconfig/nconf.c @@ -593,6 +593,8 @@ static void item_add_str(const char *fmt, ...) tmp_str, sizeof(k_menu_items[index].str)); + k_menu_items[index].str[sizeof(k_menu_items[index].str) - 1] = '\0'; + free_item(curses_menu_items[index]); curses_menu_items[index] = new_item( k_menu_items[index].str, diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c index 72b605efe549..1526c52bc34c 100644 --- a/scripts/kconfig/nconf.gui.c +++ b/scripts/kconfig/nconf.gui.c @@ -350,6 +350,7 @@ int dialog_inputbox(WINDOW *main_window, x = (columns-win_cols)/2; strncpy(result, init, *result_len); + result[*result_len - 1] = '\0'; /* create the windows */ win = newwin(win_lines, win_cols, y, x); -- 2.39.5