From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726C6335BA3; Mon, 18 Aug 2025 13:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525107; cv=none; b=nqGkupakeCqRRnRbg2Wg/2yMZIGOv9BlkjnFMpOgYzwLPh9+GCmTm+9S7Z0Oyb+vjdgwQ6rgrUCqxoqLMop46ijVTiXc0FkkSktdOne/jarqMKHwKBvXMePgbiEKPlYcr3ATcH55RaZF0nZfZF6GNjo1op6QJTJoEwHGX2TqZ1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525107; c=relaxed/simple; bh=5GoJNdhXZCO5RuSFrK7VDQ/b2hYla3lfsLrhh0YbLII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F7MJ5bCdez5HGR9jlZnwYWc/s0UU/FC9AGvsh4wNv5+6wjI7THBitjT1k3XxzrAeIrXWx+6qVYyGckHuHl3/a0go6OrxerJ8uaWG/ThBcEbTyJhXzHgIte9UPvxFHR6z9awAYy1YA73rT5/sWwDG8YQIwAfVHASdAdQ8wQJoZlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pVbwpsnx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pVbwpsnx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BEF7C4CEEB; Mon, 18 Aug 2025 13:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525107; bh=5GoJNdhXZCO5RuSFrK7VDQ/b2hYla3lfsLrhh0YbLII=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pVbwpsnx7G2QPcUpEZl8XJZRc0ySJczZ8cpy8RPOJwk5qCj7vxWezZhs9quvHq7i0 mhcV4l0HSmn6VFgxiUoY7mdPgLiAZfb4s76Gp91NDgFZ6ifqgPbB0h8ibGaYz3pxw4 oS5CqK1y/sBKwbiSrXxoOmXG6iG4zzxhHMGC9+uw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Mathias Nyman , Sasha Levin Subject: [PATCH 6.16 133/570] usb: xhci: Avoid showing warnings for dying controller Date: Mon, 18 Aug 2025 14:42:00 +0200 Message-ID: <20250818124510.947888586@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello [ Upstream commit 65fc0fc137b5da3ee1f4ca4f61050fcb203d7582 ] When a USB4 dock is unplugged from a system it won't respond to ring events. The PCI core handles the surprise removal event and notifies all PCI drivers. The XHCI PCI driver sets a flag that the device is being removed, and when the device stops responding a flag is also added to indicate it's dying. When that flag is set don't bother to show warnings about a missing controller. Signed-off-by: Mario Limonciello Signed-off-by: Mathias Nyman Acked-by: Mathias Nyman Link: https://lore.kernel.org/r/20250717073107.488599-3-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/xhci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 8a819e853288..47151ca527bf 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -121,7 +121,8 @@ int xhci_halt(struct xhci_hcd *xhci) ret = xhci_handshake(&xhci->op_regs->status, STS_HALT, STS_HALT, XHCI_MAX_HALT_USEC); if (ret) { - xhci_warn(xhci, "Host halt failed, %d\n", ret); + if (!(xhci->xhc_state & XHCI_STATE_DYING)) + xhci_warn(xhci, "Host halt failed, %d\n", ret); return ret; } @@ -180,7 +181,8 @@ int xhci_reset(struct xhci_hcd *xhci, u64 timeout_us) state = readl(&xhci->op_regs->status); if (state == ~(u32)0) { - xhci_warn(xhci, "Host not accessible, reset failed.\n"); + if (!(xhci->xhc_state & XHCI_STATE_DYING)) + xhci_warn(xhci, "Host not accessible, reset failed.\n"); return -ENODEV; } -- 2.39.5