From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69BB02C2340; Mon, 18 Aug 2025 13:35:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755524132; cv=none; b=tTtCGIwFxb3Rei8uVL/tMtkb+c/Hqh9ZJqZvkc8UazsZe1QIEZOrfGzwpHpe7TWcILxwIldtMEUEFO+magfIZQDneQJRU6WmXPO+8SCwFVHeLj3a/DSTBJKw74FRrIDTsOewPtIudI3z1pVbf0cZCCW80vNyvy7p+42ra52zrXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755524132; c=relaxed/simple; bh=K+pB83DIHNjcXKUuQbKWlTYmnMApVR7Unr7fyxSmn2w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PevfPwkL2pCilG7Aaw+g71qySh8bphtHT9TC1MQIfblLMx68IOs1MVuCdEtdgncbWOmXKCqrbTaDz0XMo0aGCMAYoWbPsqL3w56rz2O6H7cyoQNu3Fg/VRAQPukEE6/Mk0++zutJKrkRGdBUx/klDMFV6KXWTSkju2Q7ac9ABNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AWFH43Ge; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AWFH43Ge" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3712C4CEEB; Mon, 18 Aug 2025 13:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755524132; bh=K+pB83DIHNjcXKUuQbKWlTYmnMApVR7Unr7fyxSmn2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AWFH43GeEiIRrd1wiF4dLBkAdGyjQEXVdw+gv7DkOUkKyaPaKfo81R6csDDKultV8 6qor2tY4eU99g0oQnx8dZZM/7NbLi/6daCeWUGPDayllW2oJJ/diZhxhNto7TtZr90 qNWz3fjU+BLxl958RQQyqtVcL4vEfbdlVJ88CNDY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wolfram Sang , Hans Verkuil , Sasha Levin Subject: [PATCH 6.15 378/515] media: usb: hdpvr: disable zero-length read messages Date: Mon, 18 Aug 2025 14:46:04 +0200 Message-ID: <20250818124512.975298602@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124458.334548733@linuxfoundation.org> References: <20250818124458.334548733@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit b5ae5a79825ba8037b0be3ef677a24de8c063abf ] This driver passes the length of an i2c_msg directly to usb_control_msg(). If the message is now a read and of length 0, it violates the USB protocol and a warning will be printed. Enable the I2C_AQ_NO_ZERO_LEN_READ quirk for this adapter thus forbidding 0-length read messages altogether. Signed-off-by: Wolfram Sang Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/hdpvr/hdpvr-i2c.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-i2c.c b/drivers/media/usb/hdpvr/hdpvr-i2c.c index 070559b01b01..54956a8ff15e 100644 --- a/drivers/media/usb/hdpvr/hdpvr-i2c.c +++ b/drivers/media/usb/hdpvr/hdpvr-i2c.c @@ -165,10 +165,16 @@ static const struct i2c_algorithm hdpvr_algo = { .functionality = hdpvr_functionality, }; +/* prevent invalid 0-length usb_control_msg */ +static const struct i2c_adapter_quirks hdpvr_quirks = { + .flags = I2C_AQ_NO_ZERO_LEN_READ, +}; + static const struct i2c_adapter hdpvr_i2c_adapter_template = { .name = "Hauppauge HD PVR I2C", .owner = THIS_MODULE, .algo = &hdpvr_algo, + .quirks = &hdpvr_quirks, }; static int hdpvr_activate_ir(struct hdpvr_device *dev) -- 2.39.5