From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B691192598; Mon, 18 Aug 2025 13:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525235; cv=none; b=m6/tNgF8Iz/Bc4p4KmVULUfRKwHVoSgc9/IRRGygW6eRDUxQsXwwkP11ypD4WbVj6uQ9Hmc8J+SzSpBxbHsJxH/rANtfkQknPpBh0tUC5jbHk0plCWDSbHhD51PFF0z1GtGfNQp3vZJkXGtEpK486JUeSt1xQh5YlLdZxGR99ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525235; c=relaxed/simple; bh=iffVJi0roHmW5nkpKh+cSf9DMTjFOEBwjwOndWihzpU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EX6ugzhWw/3Jsan+ux4nKtMxh94NsO1RqcO2LNpqwCemjFV67S7QecffF1riDKbo3sr1ykWKV0e+tgYuHU1cwR7gv4xs7M0m0oYtGnj/ldKoC1l365dJdIvCrmYma4L6QllzLIK4uwc6ADZRTQyOhZu27EByHWPLQ2/WKKK0wJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y/IB3S0Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y/IB3S0Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E09A2C4CEEB; Mon, 18 Aug 2025 13:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525235; bh=iffVJi0roHmW5nkpKh+cSf9DMTjFOEBwjwOndWihzpU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y/IB3S0Y+xOEHZiuewU2FMOosZzLAWwjm7OnA6qXB1tnCK6vJjdzCIDBFC5Ol7TxE YU7977jFs7N4JqfoyCvVYZrtvMD1cG/Q9Lpeaqi45LvmfyxTgi4HG7Wqlg9zuG/maZ zmQ6XL2xNFZu8/PceE2xd17l0VVXnXYOBHfGyTiA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, kernel test robot , Lucy Thrun , Takashi Iwai , Sasha Levin Subject: [PATCH 6.16 199/570] ALSA: hda/ca0132: Fix buffer overflow in add_tuning_control Date: Mon, 18 Aug 2025 14:43:06 +0200 Message-ID: <20250818124513.467134014@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lucy Thrun [ Upstream commit a409c60111e6bb98fcabab2aeaa069daa9434ca0 ] The 'sprintf' call in 'add_tuning_control' may exceed the 44-byte buffer if either string argument is too long. This triggers a compiler warning. Replaced 'sprintf' with 'snprintf' to limit string lengths to prevent overflow. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202506100642.95jpuMY1-lkp@intel.com/ Signed-off-by: Lucy Thrun Link: https://patch.msgid.link/20250610175012.918-3-lucy.thrun@digital-rabbithole.de Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/pci/hda/patch_ca0132.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 77432e06f3e3..a2f57d7424bb 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -4410,7 +4410,7 @@ static int add_tuning_control(struct hda_codec *codec, } knew.private_value = HDA_COMPOSE_AMP_VAL(nid, 1, 0, type); - sprintf(namestr, "%s %s Volume", name, dirstr[dir]); + snprintf(namestr, sizeof(namestr), "%s %s Volume", name, dirstr[dir]); return snd_hda_ctl_add(codec, nid, snd_ctl_new1(&knew, codec)); } -- 2.39.5