From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F6FC31E0FE; Mon, 18 Aug 2025 14:03:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525835; cv=none; b=Mm6VGeu8Nj8WHKEF4SEJGY1kaC+9w8AfntDXjKHCgsdEGzm0dDt5YxIKscRnR4rl8HQs8gW878GB/bnaax0CJLiu2agtRiWEHku1OYP/WgVBsNXYftrJf+fyZ8aB0beJCbKim896wR5fSP9XSVHFFZ3/wjgxk26eWiaQ5+oeu70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525835; c=relaxed/simple; bh=OH5vpt1Y1lNXfEMZoWchq0SjfuoYZBDna7Gr1Abt+zU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m9b0Mc8sVpyuCQPTpbl20p763bnoqMYJpGCiR3j5yucCTvtwEYVlQzOfinDWlWuXlD3Fph7iaqKuXb8YD7bxzk5Ciy+0eOMCzl3c+B4YFLec4u3QpcZNK37CAkJ7V7xE4V19D/Tqyay8mO7HrIXlLTXVoQbbXb/9TCjatFqJUBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Mpz179fT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Mpz179fT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B78A7C4CEEB; Mon, 18 Aug 2025 14:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525835; bh=OH5vpt1Y1lNXfEMZoWchq0SjfuoYZBDna7Gr1Abt+zU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Mpz179fTUOdDhRkNg53PLEIq+Py9FoV8zlWUM+dK4Egf+UQWC1vsxTQ4Vhmcw735I T1+PWtOXggty7Qt0X2Wifk4KZg+OJXdAv+uQZ6LiR+e2CHhzEjK6mR/CsvcRjbGkGL yiYbpU2UBAqBiGg4NNsvGYAWdBwN8fQi4CtMZLps= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yonghong Song , Alexei Starovoitov , Sasha Levin Subject: [PATCH 6.16 348/570] selftests/bpf: Fix a user_ringbuf failure with arm64 64KB page size Date: Mon, 18 Aug 2025 14:45:35 +0200 Message-ID: <20250818124519.263094996@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yonghong Song [ Upstream commit bbc7bd658ddc662083639b9e9a280b90225ecd9a ] The ringbuf max_entries must be PAGE_ALIGNED. See kernel function ringbuf_map_alloc(). So for arm64 64KB page size, adjust max_entries properly. Signed-off-by: Yonghong Song Link: https://lore.kernel.org/r/20250607013626.1553001-1-yonghong.song@linux.dev Signed-off-by: Alexei Starovoitov Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/prog_tests/user_ringbuf.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c index d424e7ecbd12..9fd3ae987321 100644 --- a/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c +++ b/tools/testing/selftests/bpf/prog_tests/user_ringbuf.c @@ -21,8 +21,7 @@ #include "../progs/test_user_ringbuf.h" static const long c_sample_size = sizeof(struct sample) + BPF_RINGBUF_HDR_SZ; -static const long c_ringbuf_size = 1 << 12; /* 1 small page */ -static const long c_max_entries = c_ringbuf_size / c_sample_size; +static long c_ringbuf_size, c_max_entries; static void drain_current_samples(void) { @@ -424,7 +423,9 @@ static void test_user_ringbuf_loop(void) uint32_t remaining_samples = total_samples; int err; - BUILD_BUG_ON(total_samples <= c_max_entries); + if (!ASSERT_LT(c_max_entries, total_samples, "compare_c_max_entries")) + return; + err = load_skel_create_user_ringbuf(&skel, &ringbuf); if (err) return; @@ -686,6 +687,9 @@ void test_user_ringbuf(void) { int i; + c_ringbuf_size = getpagesize(); /* 1 page */ + c_max_entries = c_ringbuf_size / c_sample_size; + for (i = 0; i < ARRAY_SIZE(success_tests); i++) { if (!test__start_subtest(success_tests[i].test_name)) continue; -- 2.39.5