From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7EC340DB2; Mon, 18 Aug 2025 14:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525794; cv=none; b=OdQeaWGTcIzKP5JQL2MUs13cWHD5S3ylZUiD9QNqHcHYXRtirszkJNV4wfbpIBzuIBRdFXYmNycvt/7Gcsiw7t7V5Dg+qkvN/FAGK9mjY6vLvT3GnMJ4Kllwn2onvXmkkEW5kgKkjRDqGpoLWqi4+mFCoAEJ+OwFn4ByYrPOoA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525794; c=relaxed/simple; bh=9rsCTHkVGLBbNAchNgVMTiszz3G/y6Mf089WNyfy/Uo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X8EA6HoC/KmfqgDxZHeQ/X9k9cEfu+pvxLCrdxskzgZT60CqF/vBZKsTfrI71CDvAC11rCFGN/p5LjJvySX07P01bxT46/UGxdim3tfc+VztrBsTohGyiTu/cgakDn6BmdPYCDl4V8JjSEZOYpqEGQBlqhsPIJZTwL03ScrA/aE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Nx027Vr4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Nx027Vr4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A5B6C4CEEB; Mon, 18 Aug 2025 14:03:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525793; bh=9rsCTHkVGLBbNAchNgVMTiszz3G/y6Mf089WNyfy/Uo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nx027Vr4NkK5KlwWstxVicoWIP5KiPFI4Wot6OT8eNdkJpXg527KXfvsoqxrB7L51 kbdKtur5ONgBl37DN/Dbx7//uiDCvaM2uksLPIryWpTZhLcrFqQS5Mo2ixRCh0Hw3q RVRWFX6zzseeV44Bhv84bI7HoXtzNWnOqIUMtrzQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Neil Armstrong , Geraldo Nascimento , Vinod Koul , Sasha Levin Subject: [PATCH 6.16 368/570] phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal Date: Mon, 18 Aug 2025 14:45:55 +0200 Message-ID: <20250818124520.034269873@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Geraldo Nascimento [ Upstream commit 25facbabc3fc33c794ad09d73f73268c0f8cbc7d ] pcie_conf is used to touch TEST_WRITE strobe signal. This signal should be enabled, a little time waited, and then disabled. Current code clearly was copy-pasted and never disables the strobe signal. Adjust the define. While at it, remove PHY_CFG_RD_MASK which has been unused since 64cdc0360811 ("phy: rockchip-pcie: remove unused phy_rd_cfg function"). Reviewed-by: Neil Armstrong Signed-off-by: Geraldo Nascimento Link: https://lore.kernel.org/r/d514d5d5627680caafa8b7548cbdfee4307f5440.1751322015.git.geraldogabriel@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/rockchip/phy-rockchip-pcie.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-pcie.c b/drivers/phy/rockchip/phy-rockchip-pcie.c index bd44af36c67a..63e88abc66c6 100644 --- a/drivers/phy/rockchip/phy-rockchip-pcie.c +++ b/drivers/phy/rockchip/phy-rockchip-pcie.c @@ -30,9 +30,8 @@ #define PHY_CFG_ADDR_SHIFT 1 #define PHY_CFG_DATA_MASK 0xf #define PHY_CFG_ADDR_MASK 0x3f -#define PHY_CFG_RD_MASK 0x3ff #define PHY_CFG_WR_ENABLE 1 -#define PHY_CFG_WR_DISABLE 1 +#define PHY_CFG_WR_DISABLE 0 #define PHY_CFG_WR_SHIFT 0 #define PHY_CFG_WR_MASK 1 #define PHY_CFG_PLL_LOCK 0x10 -- 2.39.5