From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26699350847; Mon, 18 Aug 2025 14:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525951; cv=none; b=U0mnlXaZdpDWZGVPC/XTZ7JPH/4IDrpCAjAXh1j7hY8MtuJ2suLbGyC1nZEvIUcsPZ547sXmdUSI4JndX1YF+CYilvYy2npktYLDrYznrnZ3PVIcE5vg3nLsZGZpt0X16z30FTr3mW90AVW3y0qAkfUHqgbLMj81zLwjgsoI/hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525951; c=relaxed/simple; bh=5foh16Ac4icF+lh5+uSURLAnfZZKqvRVd/yassZaNyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bUg7POhn8xR7GkoHc3iTUu7wDErsMKpesnHr2RLaBcyQ3xYbhzzKSmQzoY/TK0aP4M8+zYnDhntAREWiilLhJj8EpGfiRcgZKnyN1Xs2OlBFsxwup8WhWOmt9dqDkN/iNj8HfM/vzp+YaWBlvgRnw92RQjLCIrOpbkDcIWZzjYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aGYQ4Op5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aGYQ4Op5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F328C4CEEB; Mon, 18 Aug 2025 14:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525951; bh=5foh16Ac4icF+lh5+uSURLAnfZZKqvRVd/yassZaNyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aGYQ4Op5vnSKb74kbmgJONweS72omyJweL6L/RQC+By3PL0I2IH/hwoL5zB7LaeVl qgkyNd4T+T0nyEVu5P4fsdV8MxHvSq2FnFcZH6lPUE4kOobD2fcAcTabT7W1uI1d0I eB3QXN9SPX5Hyr74y2dFi6ncpvMJhIVpecWvnZJ4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+cffd18309153948f3c3e@syzkaller.appspotmail.com, Arnaud Lecomte , Dave Kleikamp , Sasha Levin Subject: [PATCH 6.16 381/570] jfs: upper bound check of tree index in dbAllocAG Date: Mon, 18 Aug 2025 14:46:08 +0200 Message-ID: <20250818124520.527205482@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaud Lecomte [ Upstream commit c214006856ff52a8ff17ed8da52d50601d54f9ce ] When computing the tree index in dbAllocAG, we never check if we are out of bounds realative to the size of the stree. This could happen in a scenario where the filesystem metadata are corrupted. Reported-by: syzbot+cffd18309153948f3c3e@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=cffd18309153948f3c3e Tested-by: syzbot+cffd18309153948f3c3e@syzkaller.appspotmail.com Signed-off-by: Arnaud Lecomte Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 5a877261c3fe..cdfa699cd7c8 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -1389,6 +1389,12 @@ dbAllocAG(struct bmap * bmp, int agno, s64 nblocks, int l2nb, s64 * results) (1 << (L2LPERCTL - (bmp->db_agheight << 1))) / bmp->db_agwidth; ti = bmp->db_agstart + bmp->db_agwidth * (agno & (agperlev - 1)); + if (ti < 0 || ti >= le32_to_cpu(dcp->nleafs)) { + jfs_error(bmp->db_ipbmap->i_sb, "Corrupt dmapctl page\n"); + release_metapage(mp); + return -EIO; + } + /* dmap control page trees fan-out by 4 and a single allocation * group may be described by 1 or 2 subtrees within the ag level * dmap control page, depending upon the ag size. examine the ag's -- 2.39.5