From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2161350843; Mon, 18 Aug 2025 14:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525893; cv=none; b=C4jzUGyfrKWRFf/8n8ITO+VlLKovCGavskpPqROA65epqQ1JK/se/lsWTUE6xmhF7FDVbnmvlvPQvvLxXtxX8tiJHtigbjsJhJJVc3yBOZBFjCEaZVOj/xET7jRXwrNnMjCbwrvmndCDvpWUvXZvfuQ2aG75ITNeEQMtwfbgzhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755525893; c=relaxed/simple; bh=rUPewmHaC7f7aJSlRxAZZcgf7Oekfcq0jQZNOubfueo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OYfgSkRuGCaAjLKyWS/n1XlM4OCpz1vqdrwiEKRQkBwsb+3gafTcKvMcHaJaxyTkZsnV0V9vF5fCsjzY1rt8MmizTHVxq7ampFOY3SS2uBXEpu8RrLHlFelcd/dFvP4cjAvX0ylD+vAoCulgfkRkegCa6fd7nd6k+3TWPLpTNOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eesUEA3E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eesUEA3E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAE72C4CEEB; Mon, 18 Aug 2025 14:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755525893; bh=rUPewmHaC7f7aJSlRxAZZcgf7Oekfcq0jQZNOubfueo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eesUEA3EhKZjh6vPIO/b6YX7JiNO+XJ1pPK/H7YO1JbejIB5THI9q0pnwfBKWZctt /e7z6gi9eJcPfU///TWAUWSAIHDh2aMb9tcNmCsPElKrS7/QhVCmKlNuy0hWRFq/BW WQL1DG67eQHw/Vw6SfY8fRHk7K+d4IBR3ptbEBVM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Justin Tee , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 6.16 397/570] scsi: lpfc: Ensure HBA_SETUP flag is used only for SLI4 in dev_loss_tmo_callbk Date: Mon, 18 Aug 2025 14:46:24 +0200 Message-ID: <20250818124521.151583989@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Justin Tee [ Upstream commit 1cced5779e7a3ff7ec025fc47c76a7bd3bb38877 ] For SLI3, the HBA_SETUP flag is never set so the lpfc_dev_loss_tmo_callbk always early returns. Add a phba->sli_rev check for SLI4 mode so that the SLI3 path can flow through the original dev_loss_tmo worker thread design to lpfc_dev_loss_tmo_handler instead of early return. Signed-off-by: Justin Tee Link: https://lore.kernel.org/r/20250618192138.124116-9-justintee8345@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index b88e54a7e65c..3962f07c9140 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -183,7 +183,8 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) /* Don't schedule a worker thread event if the vport is going down. */ if (test_bit(FC_UNLOADING, &vport->load_flag) || - !test_bit(HBA_SETUP, &phba->hba_flag)) { + (phba->sli_rev == LPFC_SLI_REV4 && + !test_bit(HBA_SETUP, &phba->hba_flag))) { spin_lock_irqsave(&ndlp->lock, iflags); ndlp->rport = NULL; -- 2.39.5