From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40D92321F2F; Mon, 18 Aug 2025 14:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526001; cv=none; b=bn4DOkPtz+aG1eb22wh4vmx+AEpboJDaGUjBG9yPCRsvlRTw/Qn7CWIeuczSw5DUDraXNJXSl3P3TGXKP54UEBB8tTlf+lnpesOD/CG5j3L1fCA1u7NY6G4l1gomBLi9GulEmt9n42VNsOhsjffbhoVVINykhiLamaW2VNUuhzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526001; c=relaxed/simple; bh=R2fE6NlI20T3vHkeVxa4Y0DcgPqy9D/5eRg0qFCsqAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jNRyluJ3CsVG/oKnTkM9OTTE6N27Cy0V7sa0p/5cV/OqsSnCyaJCZG/CT065f6akz92w5BZB+1id2eTdzlL/akR/xacSzlvEFUY31/Dpf27ZuITROvoJZVz6vZA8f3xOEtq3PDCYdsWBoRzXDzXdUww+Tyf+TEfsWrNJ8p3Ario= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l8Kva2H0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l8Kva2H0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74982C2BCB9; Mon, 18 Aug 2025 14:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755526000; bh=R2fE6NlI20T3vHkeVxa4Y0DcgPqy9D/5eRg0qFCsqAM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l8Kva2H0iFke/gYE1WpfnsStfAw/V3LrKbRqm1L3Wu0Tv6xF1nPwVirAJVV6/bO5E Mn5/PVRkLhc9jNjM6MqsXDqOb4t/YwpTyXj/3yfzGKPTlNAd5pWhqEKGI1upE1rZ3y Whgy9em0wZOGsSUcmNd6X3aw221whsevL9Gr7a9o= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alex Guo , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 6.16 412/570] media: dvb-frontends: dib7090p: fix null-ptr-deref in dib7090p_rw_on_apb() Date: Mon, 18 Aug 2025 14:46:39 +0200 Message-ID: <20250818124521.719797037@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Guo [ Upstream commit ce5cac69b2edac3e3246fee03e8f4c2a1075238b ] In dib7090p_rw_on_apb, msg is controlled by user. When msg[0].buf is null and msg[0].len is zero, former checks on msg[0].buf would be passed. If accessing msg[0].buf[2] without sanity check, null pointer deref would happen. We add check on msg[0].len to prevent crash. Similar issue occurs when access msg[1].buf[0] and msg[1].buf[1]. Similar commit: commit 0ed554fd769a ("media: dvb-usb: az6027: fix null-ptr-deref in az6027_i2c_xfer()") Signed-off-by: Alex Guo Link: https://lore.kernel.org/r/20250616013231.730221-1-alexguo1023@gmail.com Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/dib7000p.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/media/dvb-frontends/dib7000p.c b/drivers/media/dvb-frontends/dib7000p.c index b40daf242046..360a2d7dd3ed 100644 --- a/drivers/media/dvb-frontends/dib7000p.c +++ b/drivers/media/dvb-frontends/dib7000p.c @@ -2256,8 +2256,12 @@ static int dib7090p_rw_on_apb(struct i2c_adapter *i2c_adap, u16 word; if (num == 1) { /* write */ + if (msg[0].len < 3) + return -EOPNOTSUPP; dib7000p_write_word(state, apb_address, ((msg[0].buf[1] << 8) | (msg[0].buf[2]))); } else { + if (msg[1].len < 2) + return -EOPNOTSUPP; word = dib7000p_read_word(state, apb_address); msg[1].buf[0] = (word >> 8) & 0xff; msg[1].buf[1] = (word) & 0xff; -- 2.39.5