From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE1D5261B9B; Mon, 18 Aug 2025 14:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526044; cv=none; b=ATM9JTbj3e0WCDRYAywDkQu+O7zpGxrwSM3+nhp5ih/5h4B/UKy7BrjwKwyzuUBxDLukI5GnlPZWxf5LNkiHkNzMvEy50n4h3aQ0NPXRxB1axUk/Ld0+5wrztiImwNFeywOUd+hvLVX9j1JMCTpvCc0gZlGNsxcNqpGqfN0X6xw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526044; c=relaxed/simple; bh=BxNoBEGXtoN4BHHwaz3DJc5v0YRUAwet/T6iKQzrNdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wc8G9SuB9BKTVi9Zzq7yCnQYAnFqphc1qEpCUm7xVlpuA8M8n3g9aN6xrjyLMDFJwGhgrW0qwVfBpH1iRxJYB8CdVAPZOLhMjhDaAgWQM9sOk+AXBVcISbRVO/WyFmde3EP66CkPcuB6kuV5w+/Bbo5nrsdM2jBM6Yf+goE5rI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KGg6yz9M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KGg6yz9M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F14FC4CEEB; Mon, 18 Aug 2025 14:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1755526044; bh=BxNoBEGXtoN4BHHwaz3DJc5v0YRUAwet/T6iKQzrNdw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KGg6yz9MDRHzVfmHu+NEcYgVe747fdoNoNSHmbtJtDw3hNdM3+pUddi+J637qgxOD NhB5Igsxtu8mpQPevMmONmA/gWiHSbW3XHN6whLZxVFkORasamg10zm4AiOjUuoA7s uz5qEV0YaOMjykfHg91ld2kQhDVocHSXQ4vKHWOs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shankari Anand , Masahiro Yamada , Randy Dunlap , Nicolas Schier , Sasha Levin Subject: [PATCH 6.16 441/570] kconfig: nconf: Ensure null termination where strncpy is used Date: Mon, 18 Aug 2025 14:47:08 +0200 Message-ID: <20250818124522.806830759@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818124505.781598737@linuxfoundation.org> References: <20250818124505.781598737@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shankari Anand [ Upstream commit f468992936894c9ce3b1659cf38c230d33b77a16 ] strncpy() does not guarantee null-termination if the source string is longer than the destination buffer. Ensure the buffer is explicitly null-terminated to prevent potential string overflows or undefined behavior. Signed-off-by: Shankari Anand Signed-off-by: Masahiro Yamada Acked-by: Randy Dunlap Tested-by: Randy Dunlap Tested-by: Nicolas Schier Acked-by: Nicolas Schier Signed-off-by: Sasha Levin --- scripts/kconfig/nconf.c | 2 ++ scripts/kconfig/nconf.gui.c | 1 + 2 files changed, 3 insertions(+) diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c index c0b2dabf6c89..ae1fe5f60327 100644 --- a/scripts/kconfig/nconf.c +++ b/scripts/kconfig/nconf.c @@ -593,6 +593,8 @@ static void item_add_str(const char *fmt, ...) tmp_str, sizeof(k_menu_items[index].str)); + k_menu_items[index].str[sizeof(k_menu_items[index].str) - 1] = '\0'; + free_item(curses_menu_items[index]); curses_menu_items[index] = new_item( k_menu_items[index].str, diff --git a/scripts/kconfig/nconf.gui.c b/scripts/kconfig/nconf.gui.c index 4bfdf8ac2a9a..7206437e784a 100644 --- a/scripts/kconfig/nconf.gui.c +++ b/scripts/kconfig/nconf.gui.c @@ -359,6 +359,7 @@ int dialog_inputbox(WINDOW *main_window, x = (columns-win_cols)/2; strncpy(result, init, *result_len); + result[*result_len - 1] = '\0'; /* create the windows */ win = newwin(win_lines, win_cols, y, x); -- 2.39.5