From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0E69352094; Tue, 26 Aug 2025 14:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218671; cv=none; b=IHJCnWjejU6oICq2Jhpeh7th6RW0AM7iVXL1CEZ8NJt3GUstzL3z1EY5GSfqhtvANdDtxnvnTKR9Q0V/fl6hAt1MB4Ve04T8ZSvhnzgwIuSPe0XR5KdnpQV/7zG/OOezFEZEVGVA4NNE+DxPMse4yGpnsoJergvEL8txzZlX2z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218671; c=relaxed/simple; bh=gE7FHaqPolG6trhc9uEPsvSQ20vEUTThbLfcEAAXih0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TayhxXi+tAt0m3JevetSPVlMb2kJH0tWzoDP00rOOLdUOlRNUn4zCqhasAQFWi6eE/PbVeli5EMN9tbySzfP7AL0yWGVbaD+IGiZgvBVOX2Kt7rTFpN0eZARwx8yFnWN18AN27P6OK9XQu5ctfcv5ei+S/jtIBHIC56z5qYExMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hAUPzATU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hAUPzATU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FFD2C4CEF1; Tue, 26 Aug 2025 14:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218671; bh=gE7FHaqPolG6trhc9uEPsvSQ20vEUTThbLfcEAAXih0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hAUPzATUQ6gMsFRRvqka/SU4KI/A4cOx0/Q1qaiqDs1b8LkySmrC3DSsD/cbpjbO1 FX4qpusdAvWW7aaOGcxt7PquyZZ7pBXOLMC5pYNV8osEneJYQU1rko75K6Lajl3U70 5EJKhfY7x4o1mpM7ff52JHnzdWQMkptNmWRijc0Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lifeng Zheng , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.4 081/403] cpufreq: Init policy->rwsem before it may be possibly used Date: Tue, 26 Aug 2025 13:06:47 +0200 Message-ID: <20250826110908.745780207@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lifeng Zheng [ Upstream commit d1378d1d7edb3a4c4935a44fe834ae135be03564 ] In cpufreq_policy_put_kobj(), policy->rwsem is used. But in cpufreq_policy_alloc(), if freq_qos_add_notifier() returns an error, error path via err_kobj_remove or err_min_qos_notifier will be reached and cpufreq_policy_put_kobj() will be called before policy->rwsem is initialized. Thus, the calling of init_rwsem() should be moved to where before these two error paths can be reached. Fixes: 67d874c3b2c6 ("cpufreq: Register notifiers with the PM QoS framework") Signed-off-by: Lifeng Zheng Link: https://patch.msgid.link/20250709104145.2348017-3-zhenglifeng1@huawei.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/cpufreq/cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 2a2fea6743aa..00f12d23077c 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1220,6 +1220,8 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) goto err_free_real_cpus; } + init_rwsem(&policy->rwsem); + freq_constraints_init(&policy->constraints); policy->nb_min.notifier_call = cpufreq_notifier_min; @@ -1242,7 +1244,6 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) } INIT_LIST_HEAD(&policy->policy_list); - init_rwsem(&policy->rwsem); spin_lock_init(&policy->transition_lock); init_waitqueue_head(&policy->transition_wait); INIT_WORK(&policy->update, handle_update); -- 2.39.5