From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D520835CECE; Tue, 26 Aug 2025 14:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218707; cv=none; b=LLvE09FqnsjY4KXOUBElEoEumZvnjxh9rTcjDb/XYR8V27kSR/bzBrHfvpcKXL/I4HWv+W34rEzfifZTwE4jo4QVussmFil2jiQ0ejg37D8YA6JiITsyPMO8sKmp3Hw4HdwHBEFCCV04FKsfYqnJkr8yJpKrOC0YgZq/w4Ku/c8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218707; c=relaxed/simple; bh=TmWcI8BBVkTQc/WFpKfDPMKHZld6s0AbjBbR0WQqZ4Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bBZKR+s/fyG2bPhjM+Vrsg6L0Cq/g1245U5DSfilvoqTv/jHn3VRIXlGMNV8Sa2EJCfJglpOXF5C9QroitdDsT09RFhunvxAXiUB4/Z3KWjwijril1+2x8bjTr0pOSTyNgDnnB5edFEvlIKhJAKiSrJZLD6oaa9zaY5MCboVldE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hYSTnQyd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hYSTnQyd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62107C113CF; Tue, 26 Aug 2025 14:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218707; bh=TmWcI8BBVkTQc/WFpKfDPMKHZld6s0AbjBbR0WQqZ4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hYSTnQydof0lisbEM16t2UI3YoZbThCFwX/kxhEhmjWpXgniCS1UhScpRUxGdhmrj lRO8GYld6NAYkpaKsk3BbCJHLS2XW8x90brM1GAK2K8NliXMUm9yVWlMaUacxdOr++ dX+wCk50DWXWtFmfmuKRxpgP3nwZJAWAgGe7/yKU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+4ff165b9251e4d295690@syzkaller.appspotmail.com, Florian Westphal , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.4 102/403] netfilter: xt_nfacct: dont assume acct name is null-terminated Date: Tue, 26 Aug 2025 13:07:08 +0200 Message-ID: <20250826110909.495261572@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Florian Westphal [ Upstream commit bf58e667af7d96c8eb9411f926a0a0955f41ce21 ] BUG: KASAN: slab-out-of-bounds in .. lib/vsprintf.c:721 Read of size 1 at addr ffff88801eac95c8 by task syz-executor183/5851 [..] string+0x231/0x2b0 lib/vsprintf.c:721 vsnprintf+0x739/0xf00 lib/vsprintf.c:2874 [..] nfacct_mt_checkentry+0xd2/0xe0 net/netfilter/xt_nfacct.c:41 xt_check_match+0x3d1/0xab0 net/netfilter/x_tables.c:523 nfnl_acct_find_get() handles non-null input, but the error printk relied on its presence. Reported-by: syzbot+4ff165b9251e4d295690@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=4ff165b9251e4d295690 Tested-by: syzbot+4ff165b9251e4d295690@syzkaller.appspotmail.com Fixes: ceb98d03eac5 ("netfilter: xtables: add nfacct match to support extended accounting") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/xt_nfacct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/xt_nfacct.c b/net/netfilter/xt_nfacct.c index 5aab6df74e0f..68b07476f754 100644 --- a/net/netfilter/xt_nfacct.c +++ b/net/netfilter/xt_nfacct.c @@ -38,8 +38,8 @@ nfacct_mt_checkentry(const struct xt_mtchk_param *par) nfacct = nfnl_acct_find_get(par->net, info->name); if (nfacct == NULL) { - pr_info_ratelimited("accounting object `%s' does not exists\n", - info->name); + pr_info_ratelimited("accounting object `%.*s' does not exist\n", + NFACCT_NAME_MAX, info->name); return -ENOENT; } info->nfacct = nfacct; -- 2.39.5