From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ABB235690B; Tue, 26 Aug 2025 14:32:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218739; cv=none; b=McB/bu4UWeJVriJwK6mOutkDf1RZPKEx077WnlPO8SrJESK+pNauLI+RKA+4bg5y7hvJaSPSh0TGGmphF+ZNKoDThMHfpfTNyEWqGixbxjjGepp4vmD0lA/3JO5QJkCLrIl3RdHcA8DzJQU2Zym1RoyBOkzlDF5V1GRSsMLFaUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218739; c=relaxed/simple; bh=rN8ONQTUaHtJQ+yRqPi7rzk5rHzIR+T5Z3Jbui2cH5I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GghT3yLp7BiG57h7St36JQCwenZCFyhrKfr1x6ZUE5VmkCYKFaWrqXzzLgt7ZhuunQ/bLW0hY0Is9AVYgs8ECeSs7o8tEXyoF6DQsx5GhYbP9VbuUQT9CSbAgQN6NEHQKsvq/Tr6ZrAu0YsVMcjIPOJos5KE1qkKe6YgUyZ3+Vg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=C0j56qAu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="C0j56qAu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EA04C4CEF1; Tue, 26 Aug 2025 14:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218738; bh=rN8ONQTUaHtJQ+yRqPi7rzk5rHzIR+T5Z3Jbui2cH5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C0j56qAup5mz2uEAVG9hzl5aFEokmknhim+tBInMNN1WLJ8Ukfwk3GdWq42fxnmOc vdmXY74DaH08fXscDQQkZpyFe/fkwmP9OM/aHVx3hWrj90xvWyoJTQZvuP3PKCbFFA dgsFzkCID27jQbUhe9qWT5AEbzqUOiXwJ0VDZHZ0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paul Kocialkowski , Chen-Yu Tsai , Sasha Levin Subject: [PATCH 5.4 113/403] clk: sunxi-ng: v3s: Fix de clock definition Date: Tue, 26 Aug 2025 13:07:19 +0200 Message-ID: <20250826110909.854415216@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paul Kocialkowski [ Upstream commit e8ab346f9907a1a3aa2f0e5decf849925c06ae2e ] The de clock is marked with CLK_SET_RATE_PARENT, which is really not necessary (as confirmed from experimentation) and significantly restricts flexibility for other clocks using the same parent. In addition the source selection (parent) field is marked as using 2 bits, when it the documentation reports that it uses 3. Fix both issues in the de clock definition. Fixes: d0f11d14b0bc ("clk: sunxi-ng: add support for V3s CCU") Signed-off-by: Paul Kocialkowski Link: https://patch.msgid.link/20250704154008.3463257-1-paulk@sys-base.io Signed-off-by: Chen-Yu Tsai Signed-off-by: Sasha Levin --- drivers/clk/sunxi-ng/ccu-sun8i-v3s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c index 0e36ca3bf3d5..4fddb489cdce 100644 --- a/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c +++ b/drivers/clk/sunxi-ng/ccu-sun8i-v3s.c @@ -334,8 +334,7 @@ static SUNXI_CCU_GATE(dram_ohci_clk, "dram-ohci", "dram", static const char * const de_parents[] = { "pll-video", "pll-periph0" }; static SUNXI_CCU_M_WITH_MUX_GATE(de_clk, "de", de_parents, - 0x104, 0, 4, 24, 2, BIT(31), - CLK_SET_RATE_PARENT); + 0x104, 0, 4, 24, 3, BIT(31), 0); static const char * const tcon_parents[] = { "pll-video" }; static SUNXI_CCU_M_WITH_MUX_GATE(tcon_clk, "tcon", tcon_parents, -- 2.39.5