From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847CE2AD32; Tue, 26 Aug 2025 14:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218767; cv=none; b=cimfJcazocEISuKoxvUni1CcijBMedgk/5y3VE4Sv407vcPwoLZDxY7FmwnGdUIeTyliPLqTvouz7KupAysd8GTGebfkMG6pxXVX+jmMJAtUdRG0gZuKOPi6oNG+/nRfBIBz87HW5Y+cdKZgHSpjKQWm79qVX4Fn6EZJdiAI/h4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218767; c=relaxed/simple; bh=izCwNyT877laCACwvlYbZ7W2E3rw/nER3vNRdx8tw3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=shHuRztMRCKzXEojQ5ReFydAQDxXm0rbV0mqk8WngpjLP3IyFUwY5KYintxBZVEgEYdrUBpQsyMf6rJQYpcHHzsKyaXb0WAJhJyzNrGiHGx702lwJoHv54xfXfZrr16mAVj4eKDimzdCgQc8Z6W00iLJP8alTdxI/hSFcltZgi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MNltVAN+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MNltVAN+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C92C4CEF1; Tue, 26 Aug 2025 14:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218767; bh=izCwNyT877laCACwvlYbZ7W2E3rw/nER3vNRdx8tw3g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MNltVAN+K75Lj61ktnKjpPkkkYouR1KGba4gFhq1HGG8Vl03ctaXORzYIOxrgoQaN GRAZvDB1ywRXnI1muwIU5K53whrINcM3gMQ+qh4TpoeunBAQJMewvoBD0345D+llaW PCQAP1D4dDehDUUuylOxZcCqZU3vPTDe+hpaKmhc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zheng Yu , Dave Kleikamp , Sasha Levin Subject: [PATCH 5.4 126/403] jfs: fix metapage reference count leak in dbAllocCtl Date: Tue, 26 Aug 2025 13:07:32 +0200 Message-ID: <20250826110910.220955841@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zheng Yu [ Upstream commit 856db37592021e9155384094e331e2d4589f28b1 ] In dbAllocCtl(), read_metapage() increases the reference count of the metapage. However, when dp->tree.budmin < 0, the function returns -EIO without calling release_metapage() to decrease the reference count, leading to a memory leak. Add release_metapage(mp) before the error return to properly manage the metapage reference count and prevent the leak. Fixes: a5f5e4698f8abbb25fe4959814093fb5bfa1aa9d ("jfs: fix shift-out-of-bounds in dbSplit") Signed-off-by: Zheng Yu Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/jfs_dmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 8cffb5dd98cf..15f885d2fa3d 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -1875,8 +1875,10 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results) return -EIO; dp = (struct dmap *) mp->data; - if (dp->tree.budmin < 0) + if (dp->tree.budmin < 0) { + release_metapage(mp); return -EIO; + } /* try to allocate the blocks. */ -- 2.39.5