From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662B3352074; Tue, 26 Aug 2025 14:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218783; cv=none; b=ScrQu70s2VIbOKWn0Q86rgY9ElfPTfMkv8fTPK632lXWHGGH6iOfm4aMgH57KmeJL1BnebJOz1YAsdQ/BANjHBouZUFhIb6aSTJwivTzFRGjqx6xlavYZ0MUtFvIkUT3+YB7SKAqHtESCOGtSz6Ob37S/ZnuKheV6BceeNgRtqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218783; c=relaxed/simple; bh=JVR8Y3D4P7LHHYFERAGly4grRCpIoGgmNSiC55WnZ7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dNflPYPonzqhPpgv2wBq+k0RATNqb9CvYMTnF5/V5bcgQKCCeMvJx+TGpCFYDzYatKL8upAdufibGNaA7xrWyMSh46YOXIZdhZFc6YbxcfjxmuDs5spN5AgJqeWuE3XPFAELIwCMJNAJwwjXWD51q+rBcNLWKyzyyDZF/TCHib0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DPlExKqD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DPlExKqD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED96AC116B1; Tue, 26 Aug 2025 14:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218783; bh=JVR8Y3D4P7LHHYFERAGly4grRCpIoGgmNSiC55WnZ7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DPlExKqDN9fd5M2UQVyvOliYTXwqFP5coVyfBwoXObUlnqaRUH1arDIa41Sh1a4gA SBmnp2Eu4no004lN/acG5DTOZ0cA5WA95fnnoSwtkD68xRw0VFioGlFRhCnbKc4mox jrlETbgt6N2BNvb2+fBEjPK2PhUf7KkFDTh/y8XI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Brian Masney , Alexandre Belloni , Sasha Levin Subject: [PATCH 5.4 132/403] rtc: hym8563: fix incorrect maximum clock rate handling Date: Tue, 26 Aug 2025 13:07:38 +0200 Message-ID: <20250826110910.388399803@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Brian Masney [ Upstream commit d0a518eb0a692a2ab8357e844970660c5ea37720 ] When hym8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: dcaf038493525 ("rtc: add hym8563 rtc-driver") Signed-off-by: Brian Masney Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index fb6d7967ec00..bd625ab70617 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -316,7 +316,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate, if (clkout_rates[i] <= rate) return clkout_rates[i]; - return 0; + return clkout_rates[0]; } static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.39.5