From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39D334DCC3; Tue, 26 Aug 2025 14:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218931; cv=none; b=Y3Iv3pLUa5EQB51JA+hU8x8iYG7X15fwZwsQN10FS5wV9HPUInpultlEw9aZr24xFgzkUKXFdyUD1II9WcobJJEdayVIVT7uxQiqcJlLQnAJIknseB4dbuhQ65pjdMBY0duA3/x3yHd8bMDBsYzWOhb+I0xOCyX0CtaOBqLCZvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218931; c=relaxed/simple; bh=MKR2ae4VlA894Jp6CfeCLuEJHQvSieeHlix0PSSGiPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BSjnuBNLEh6CDZcoQc51qdrCd9vUTT6Qza8rufeCl3Q0SyTIt48G9RBbL0NBIy9hSAqMw+ZIT46AAyp9uNuheOwLSJkMX/B5PzXJTtY3YLTLF7KDRz6WBMQHl01hZCvgVxhlLeSFOgdAedFzv9TZ398rC41kNgnxX99O+32Qzo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0Gcyu674; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0Gcyu674" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7723CC4CEF1; Tue, 26 Aug 2025 14:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218930; bh=MKR2ae4VlA894Jp6CfeCLuEJHQvSieeHlix0PSSGiPI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0Gcyu674B0Fv87LT7jMDwj0KqzNXX8ZLLirQPMPlyZXgaVERDxJBnEFJdcD1SKeCV 3MA1d3oWfMcpaqp9Ff7LXJhfebs+dYdOuCkabQVKjgQ7FIJuon1j7s0m4fA3l90yCx oEoU5CPbNDqhwTCvMtWC1acvVuN+f8FsgSesKF6c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai , Youngjun Lee Subject: [PATCH 5.4 157/403] ALSA: usb-audio: Validate UAC3 power domain descriptors, too Date: Tue, 26 Aug 2025 13:08:03 +0200 Message-ID: <20250826110911.218818802@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit d832ccbc301fbd9e5a1d691bdcf461cdb514595f upstream. UAC3 power domain descriptors need to be verified with its variable bLength for avoiding the unexpected OOB accesses by malicious firmware, too. Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") Reported-and-tested-by: Youngjun Lee Cc: Link: https://patch.msgid.link/20250814081245.8902-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/usb/validate.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/sound/usb/validate.c +++ b/sound/usb/validate.c @@ -221,6 +221,17 @@ static bool validate_uac3_feature_unit(c return d->bLength >= sizeof(*d) + 4 + 2; } +static bool validate_uac3_power_domain_unit(const void *p, + const struct usb_desc_validator *v) +{ + const struct uac3_power_domain_descriptor *d = p; + + if (d->bLength < sizeof(*d)) + return false; + /* baEntities[] + wPDomainDescrStr */ + return d->bLength >= sizeof(*d) + d->bNrEntities + 2; +} + static bool validate_midi_out_jack(const void *p, const struct usb_desc_validator *v) { @@ -285,6 +296,7 @@ static const struct usb_desc_validator a struct uac3_clock_multiplier_descriptor), /* UAC_VERSION_3, UAC3_SAMPLE_RATE_CONVERTER: not implemented yet */ /* UAC_VERSION_3, UAC3_CONNECTORS: not implemented yet */ + FUNC(UAC_VERSION_3, UAC3_POWER_DOMAIN, validate_uac3_power_domain_unit), { } /* terminator */ };