From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21500353366; Tue, 26 Aug 2025 14:34:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218856; cv=none; b=IILr532VEEp+wr7Qd+KuwC+kVwCBgyTYzUWok+K1He0ZNDANQtawGBQ8EhZ59V+9dyuD3VF/kJWo9fN9cFkU5AB7I4/NlI8m7I71N8EmWoSfCIaiQYsa9MNWSNfHiIvsX5Ng/vXmMLDAti389tc/6FB6uJMoWs+X+pKSldZw0Tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218856; c=relaxed/simple; bh=hcCsTJnk7y+IAk1FCA7lJ3E/iR8sb6FMisRbJPYhH+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s6wivnNcENZcyq7xq9f6V0nFSx9jE3tDA2GriYUZUUuCGZoTWEUXaKM7oxtTIHBLvu3uxoOgkmjRCmPOkz1LLZeg36H5cw1z6jZCSnBWAn5bigGQWvpOvvSHKJT3TqEY5JJesGbznB26ROrfQhwYcPsrE5XZfuXuZ9tEyaFZYZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HvyKT/y/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HvyKT/y/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA2F0C4CEF1; Tue, 26 Aug 2025 14:34:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218856; bh=hcCsTJnk7y+IAk1FCA7lJ3E/iR8sb6FMisRbJPYhH+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HvyKT/y/Mh1bUNWOgBoWrkUncAvROr4ts50hErPsGGMXY7ln1olI4+nzkPF5xYQR1 xH+cNHw4lYdbNcLaKqUMhwHcau1YZipLq0ZVSc6DVaHIMS/lvvZvgULdFUmaq74brt ygVdCsXxK83AwZIn1sd0TumpgW7sltZLjy25w1nA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yangbo Lu , Johan Hovold , Simon Horman , Jakub Kicinski Subject: [PATCH 5.4 160/403] net: gianfar: fix device leak when querying time stamp info Date: Tue, 26 Aug 2025 13:08:06 +0200 Message-ID: <20250826110911.300756362@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit da717540acd34e5056e3fa35791d50f6b3303f55 upstream. Make sure to drop the reference to the ptp device taken by of_find_device_by_node() when querying the time stamping capabilities. Note that holding a reference to the ptp device does not prevent its driver data from going away. Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata") Cc: stable@vger.kernel.org # 4.18 Cc: Yangbo Lu Signed-off-by: Johan Hovold Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250725171213.880-4-johan@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1490,8 +1490,10 @@ static int gfar_get_ts_info(struct net_d if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); of_node_put(ptp_node); - if (ptp_dev) + if (ptp_dev) { ptp = platform_get_drvdata(ptp_dev); + put_device(&ptp_dev->dev); + } } if (ptp)