From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFCB53568E4; Tue, 26 Aug 2025 14:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218858; cv=none; b=FpSwCT2dlxnoLIDkIYh+DVzNmlLbOJhnbc7v0rrKYgBqPvb4WdWOATwtMVvZf3z6jLyJVc2YtTBiq3z3bMQudKzn4+qdq7My83fWgLKMzL5P4Tp9QvsHezU39yVPB4/WWTitJxGYRygaKGrFFJnpf1y7B00DhjOHdmtgTAmNeEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218858; c=relaxed/simple; bh=ARRBAEy/HosSbQ9uF1/Uj6IUK4PxIH07dhPiPFSQIO0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XzEIrajdtpyHccjdqKG6eGFfS8iTmGBzfhnpg0Xs94dj5SArWTSWR9jdOml5ZYcCOUCtNV7Lj9inXcLwK++t8aR8o9xtzFUuR6ksjuc+Pd3WBrmL6YkxckSAOufN8nRvz2VyYSR0NYkwcYXNmOZP9FYmMtfn0WIZ0qmwvs6klK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S6n5BfPv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S6n5BfPv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F27CC4CEF1; Tue, 26 Aug 2025 14:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218858; bh=ARRBAEy/HosSbQ9uF1/Uj6IUK4PxIH07dhPiPFSQIO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S6n5BfPvb9238hiaHPwEgBhRpXTTLzad3rY4UClpiDNNxwAd1Sic56HfRkn1pgm7T xx9O8PbujBm2d4VsqnLLecAawU1VajWZNyloD7yd+3ft8F+wRZiHNKE7X7sXgFcHZ4 McFmf/P/9qulThV9pMemCub6U4D+3Moq8NCBG1vg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yangbo Lu , Johan Hovold , Simon Horman , Jakub Kicinski Subject: [PATCH 5.4 161/403] net: dpaa: fix device leak when querying time stamp info Date: Tue, 26 Aug 2025 13:08:07 +0200 Message-ID: <20250826110911.330320996@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 3fa840230f534385b34a4f39c8dd313fbe723f05 upstream. Make sure to drop the reference to the ptp device taken by of_find_device_by_node() when querying the time stamping capabilities. Note that holding a reference to the ptp device does not prevent its driver data from going away. Fixes: 17ae0b0ee9db ("dpaa_eth: add the get_ts_info interface for ethtool") Cc: stable@vger.kernel.org # 4.19 Cc: Yangbo Lu Signed-off-by: Johan Hovold Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250725171213.880-2-johan@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c @@ -516,8 +516,10 @@ static int dpaa_get_ts_info(struct net_d of_node_put(ptp_node); } - if (ptp_dev) + if (ptp_dev) { ptp = platform_get_drvdata(ptp_dev); + put_device(&ptp_dev->dev); + } if (ptp) info->phc_index = ptp->phc_index;