From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A235E35E4EA; Tue, 26 Aug 2025 14:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218995; cv=none; b=tbBqJNleX5ZmDKQR5UGWcGq4EJ2qFrL3QysKSZV0uYPmFv4i+8ljPMsjlCTdpXMlIa/d1HB2K18fA7fRjFBz+r42c9e2JT5JvZ5T4lekDBjTaMFa9YZ2+PWQ+ub4EtKGkaBd0qHLEh4ZBOr2zwrepug8b/0dPhIeIA7tzNnKYW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218995; c=relaxed/simple; bh=kf5FfVf8uFQ7QmXvGxgEkcMYZL6GoyRpEIBjz6MtDTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0POKym7fD5XvozJAEJj/FF3cFtFeckHuCeJa1pgZpx4+SGME3UTL+rX7/71riUs51AhN6SRN2/BvLprCaC0ckLCyxMReghAKxBovJyoDPGuQsqK/Hv2zSH4Uq89lUuJeOFWJCeUmjOLwBn9a3DOsU3wodR7CwghZURgoIXTVXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qNpS9gku; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qNpS9gku" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 361ABC4CEF1; Tue, 26 Aug 2025 14:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218995; bh=kf5FfVf8uFQ7QmXvGxgEkcMYZL6GoyRpEIBjz6MtDTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qNpS9gkuqYEmZEghP8fWhP4jMW3PwpkrlCE2107tAW6KaJHuduWYGPILmkSfEjp0b 3Mv200mNkw96hFK7I6lfnlxwaUuWp5GbqqzPCk+KHV/Way/nyPcMIYZQqh+TjSB59j Zmva0msO4fpbIaYPmlZAsv0QSXFWevtxJwPm35co= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Mathias Nyman , Sasha Levin Subject: [PATCH 5.4 185/403] usb: xhci: Avoid showing errors during surprise removal Date: Tue, 26 Aug 2025 13:08:31 +0200 Message-ID: <20250826110911.993080913@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mario Limonciello [ Upstream commit 4b9c60e440525b729ac5f071e00bcee12e0a7e84 ] When a USB4 dock is unplugged from a system it won't respond to ring events. The PCI core handles the surprise removal event and notifies all PCI drivers. The XHCI PCI driver sets a flag that the device is being removed as well. When that flag is set don't show messages in the cleanup path for marking the controller dead. Signed-off-by: Mario Limonciello Signed-off-by: Mathias Nyman Acked-by: Mathias Nyman Link: https://lore.kernel.org/r/20250717073107.488599-2-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/xhci-ring.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 71b17a00d3ed..47326fb8b1fc 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -973,12 +973,15 @@ static void xhci_kill_endpoint_urbs(struct xhci_hcd *xhci, */ void xhci_hc_died(struct xhci_hcd *xhci) { + bool notify; int i, j; if (xhci->xhc_state & XHCI_STATE_DYING) return; - xhci_err(xhci, "xHCI host controller not responding, assume dead\n"); + notify = !(xhci->xhc_state & XHCI_STATE_REMOVING); + if (notify) + xhci_err(xhci, "xHCI host controller not responding, assume dead\n"); xhci->xhc_state |= XHCI_STATE_DYING; xhci_cleanup_command_queue(xhci); @@ -992,7 +995,7 @@ void xhci_hc_died(struct xhci_hcd *xhci) } /* inform usb core hc died if PCI remove isn't already handling it */ - if (!(xhci->xhc_state & XHCI_STATE_REMOVING)) + if (notify) usb_hc_died(xhci_to_hcd(xhci)); } -- 2.39.5