From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C02135AAD4; Tue, 26 Aug 2025 14:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219016; cv=none; b=qlvtMf8wV+Bug8yqv0HdaAJgJwEX6b4mWblp9MCftu+e7HOfiS2191HChVhuct9+dM10kx6/BoH5cn0glrEMFIFssGCQNLt90WE27KzkS3gLNn4QkA+XD3V+j5FV2T6ajOkxZs7rsr2yLVsZ7TdLGVhfvbTJNni9JGJXAR5T/t8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756219016; c=relaxed/simple; bh=NweRU+vvUU+dYFIy8JWPZmVKNa8pbv/ZFSZEmh5PPak=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nLf1NqiCCbuuIhdVdIPnSwFmaJsYYxqwaxjXCIwGohYwse6piw/ZUS2VoZQHrlMA6HErFvzvqaxZu4fgK8OrhUxfu+dgn1gWMz/dKsG8479rNraIpDFCuqsCbK85JzXoFZAa5kErl00qehxmCGVuhJI4j+PpNs1XwcnIG58yLnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jCut3a18; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jCut3a18" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7193C4CEF1; Tue, 26 Aug 2025 14:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756219016; bh=NweRU+vvUU+dYFIy8JWPZmVKNa8pbv/ZFSZEmh5PPak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jCut3a18zcUDxrr8H0aPafSnzVOkIHYHog35PEKnZOYOJJr0GEvgm05DVK/8Lq0RG 38dT7PGNnYgBh2ZucDfBhDqHRiJkwtxkbTNPPeXesDjKIrHIsdiVWN1faEp5HwuOpg QXcGlbfWGPTH/OMBydZbbN/XNI6r79Fbwv5soQVM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bartosz Golaszewski , Sasha Levin Subject: [PATCH 5.4 189/403] gpio: tps65912: check the return value of regmap_update_bits() Date: Tue, 26 Aug 2025 13:08:35 +0200 Message-ID: <20250826110912.098618106@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bartosz Golaszewski [ Upstream commit a0b2a6bbff8c26aafdecd320f38f52c341d5cafa ] regmap_update_bits() can fail, check its return value like we do elsewhere in the driver. Link: https://lore.kernel.org/r/20250707-gpiochip-set-rv-gpio-round4-v1-2-35668aaaf6d2@linaro.org Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-tps65912.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c index 3ad68bd78282..736af805e54a 100644 --- a/drivers/gpio/gpio-tps65912.c +++ b/drivers/gpio/gpio-tps65912.c @@ -49,10 +49,13 @@ static int tps65912_gpio_direction_output(struct gpio_chip *gc, unsigned offset, int value) { struct tps65912_gpio *gpio = gpiochip_get_data(gc); + int ret; /* Set the initial value */ - regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset, - GPIO_SET_MASK, value ? GPIO_SET_MASK : 0); + ret = regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset, + GPIO_SET_MASK, value ? GPIO_SET_MASK : 0); + if (ret) + return ret; return regmap_update_bits(gpio->tps->regmap, TPS65912_GPIO1 + offset, GPIO_CFG_MASK, GPIO_CFG_MASK); -- 2.39.5