From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 282A9350D45; Tue, 26 Aug 2025 14:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218967; cv=none; b=S7IQNVwX2e5Krtyp37xakHxYIbCTpOaIoc4noPOpAJGQsnI8JiHGFVAN8dC/UmhE/hbK1v8rU40ZSZ7BSmOaJ12QHuOxePMcvcJvOCADdvoMQc523G107jo/CMkBi4Xpxhf7Hh9H2XOfL5A4a2GWNYyd7cAnbcCJBJ6b5kffyG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756218967; c=relaxed/simple; bh=iIsVZq9orTc3WwFy11sJRdidapNc7U4RCmXw8xG2B6k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nuOtfiRsAzCNuT1iqK/fmtL9ypmUDpNi2ooUvkdtgGgYPf/Lhicre41xAbFF/9GFlffYXlJmw1e+N0mzFnmJXeaP/vO361s6ffbXUHS/2zaOiwIF9PfX+RUvTBUfsb3M7c3fvX1Lh6vRZthECw5i+CtY0QoxISAfCpisSg6aiFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HhMPbZyA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HhMPbZyA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B398EC4CEF1; Tue, 26 Aug 2025 14:36:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1756218967; bh=iIsVZq9orTc3WwFy11sJRdidapNc7U4RCmXw8xG2B6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HhMPbZyAbwCcADDTu1kaYh8NFz4RZ3XUP427D+ijB41U3us+j5Iow+YgYgNXntgAF qfIww3sNmM8oaUp79i8WFlxuHWqqZWa3i9qYKsZwVyf9wjrGJXLDHzyblLGsAyCMQX cgAUP8EMw6fisVol1ppZ2aZ/0kmhvfnhdpDHEjQg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kees Cook , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Sasha Levin Subject: [PATCH 5.4 202/403] platform/x86: thinkpad_acpi: Handle KCOV __init vs inline mismatches Date: Tue, 26 Aug 2025 13:08:48 +0200 Message-ID: <20250826110912.437454137@linuxfoundation.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250826110905.607690791@linuxfoundation.org> References: <20250826110905.607690791@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kees Cook [ Upstream commit 6418a8504187dc7f5b6f9d0649c03e362cb0664b ] When KCOV is enabled all functions get instrumented, unless the __no_sanitize_coverage attribute is used. To prepare for __no_sanitize_coverage being applied to __init functions[1], we have to handle differences in how GCC's inline optimizations get resolved. For thinkpad_acpi routines, this means forcing two functions to be inline with __always_inline. Link: https://lore.kernel.org/lkml/20250523043935.2009972-11-kees@kernel.org/ [1] Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20250529181831.work.439-kees@kernel.org Signed-off-by: Ilpo Järvinen Signed-off-by: Sasha Levin --- drivers/platform/x86/thinkpad_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 9eb74d9e1519..e480fff7142a 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -514,12 +514,12 @@ static unsigned long __init tpacpi_check_quirks( return 0; } -static inline bool __pure __init tpacpi_is_lenovo(void) +static __always_inline bool __pure __init tpacpi_is_lenovo(void) { return thinkpad_id.vendor == PCI_VENDOR_ID_LENOVO; } -static inline bool __pure __init tpacpi_is_ibm(void) +static __always_inline bool __pure __init tpacpi_is_ibm(void) { return thinkpad_id.vendor == PCI_VENDOR_ID_IBM; } -- 2.39.5